Attention is currently required from: Máté Kukri, Varshit Pandya.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81529?usp=email )
Change subject: mb/dell/optiplex_9020: Implement late HWM initialization ......................................................................
Patch Set 5: Code-Review+1
(3 comments)
File src/mainboard/dell/optiplex_9020/mainboard.c:
https://review.coreboot.org/c/coreboot/+/81529/comment/83b5e521_094140e0 : PS5, Line 355: case 3:
These are the same chassis type values the vendor firmware uses. […]
Ack
https://review.coreboot.org/c/coreboot/+/81529/comment/cddfcb1e_39717453 : PS5, Line 368: die("Unknown chassis type\n");
No table results in the fan running at a low constant speed.
Can the fan still be set to run at full speed? Should work to prevent overheating.
https://review.coreboot.org/c/coreboot/+/81529/comment/8466ad7e_cbe9216a : PS5, Line 371: if (CONFIG_MAX_CPUS > 2) {
The vendor firmware bases this check on "max core address MSR" > 2 (i dont remember the id off the t […]
Ack. There are CPUs with 2 cores and 2 threads, but they're low-end.