Attention is currently required from: Máté Kukri, Varshit Pandya.

Patch set 5:Code-Review +1

View Change

3 comments:

• File src/mainboard/dell/optiplex_9020/mainboard.c:

  • Patch Set #5, Line 355: case 3:

    These are the same chassis type values the vendor firmware uses. […]

    Ack

  • Patch Set #5, Line 368: die("Unknown chassis type\n");

    No table results in the fan running at a low constant speed.

    Can the fan still be set to run at full speed? Should work to prevent overheating.

  • Patch Set #5, Line 371: if (CONFIG_MAX_CPUS > 2) {

    The vendor firmware bases this check on "max core address MSR" > 2 (i dont remember the id off the t […]

    Ack. There are CPUs with 2 cores and 2 threads, but they're low-end.

To view, visit change 81529. To unsubscribe, or for help writing mail filters, visit settings.