Shaunak Saha has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45053 )
Change subject: mb/google/volteer: Add settings for noise mitgation ......................................................................
mb/google/volteer: Add settings for noise mitgation
Enable acoustic noise mitgation for volteer platform.
BUG=b:153015585 BRANCH=none TEST= Measure the change in noise level by changing the values in devicetree.
Signed-off-by: Shaunak Saha shaunak.saha@intel.com Change-Id: I69a6453091bf607d3c5847c99bc077e6b7dbc639 --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb 1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/45053/1
diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index ffae2f0..5e33f41 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -232,6 +232,17 @@
register "tcc_offset" = "10" # TCC of 90
+ # Acoustic settings + register "AcousticNoiseMitigation" = "1" + register "SlowSlewRate[0]" = "2" + register "SlowSlewRate[1]" = "2" + register "SlowSlewRate[2]" = "2" + register "SlowSlewRate[3]" = "2" + register "FastPkgCRampDisable[0]" = "1" + register "FastPkgCRampDisable[1]" = "1" + register "FastPkgCRampDisable[2]" = "1" + register "FastPkgCRampDisable[3]" = "1" + # Intel Common SoC Config #+-------------------+---------------------------+ #| Field | Value |
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45053 )
Change subject: mb/google/volteer: Add settings for noise mitgation ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45053/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/45053/3/src/mainboard/google/voltee... PS3, Line 233: # Acoustic settings : register "AcousticNoiseMitigation" = "1" : register "SlowSlewRate[0]" = "2" : register "SlowSlewRate[1]" = "2" : register "SlowSlewRate[2]" = "2" : register "SlowSlewRate[3]" = "2" : register "FastPkgCRampDisable[0]" = "1" : register "FastPkgCRampDisable[1]" = "1" : register "FastPkgCRampDisable[2]" = "1" : register "FastPkgCRampDisable[3]" = "1" : question for the EEs: we may want to do this per variant. i'm not sure how well tunings for one board layout + component choices translates to the rest.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45053 )
Change subject: mb/google/volteer: Add settings for noise mitgation ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45053/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/45053/3/src/mainboard/google/voltee... PS3, Line 233: # Acoustic settings : register "AcousticNoiseMitigation" = "1" : register "SlowSlewRate[0]" = "2" : register "SlowSlewRate[1]" = "2" : register "SlowSlewRate[2]" = "2" : register "SlowSlewRate[3]" = "2" : register "FastPkgCRampDisable[0]" = "1" : register "FastPkgCRampDisable[1]" = "1" : register "FastPkgCRampDisable[2]" = "1" : register "FastPkgCRampDisable[3]" = "1" :
question for the EEs: […]
Yes, these changes should be made in the override tree for the variant.
Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45053 )
Change subject: mb/google/volteer: Add settings for noise mitgation ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45053/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/45053/3/src/mainboard/google/voltee... PS3, Line 233: # Acoustic settings : register "AcousticNoiseMitigation" = "1" : register "SlowSlewRate[0]" = "2" : register "SlowSlewRate[1]" = "2" : register "SlowSlewRate[2]" = "2" : register "SlowSlewRate[3]" = "2" : register "FastPkgCRampDisable[0]" = "1" : register "FastPkgCRampDisable[1]" = "1" : register "FastPkgCRampDisable[2]" = "1" : register "FastPkgCRampDisable[3]" = "1" :
Yes, these changes should be made in the override tree for the variant.
Will use these in override cb files.
Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Caveh Jalali, Eric Herrmann, Duncan Laurie, Tim Wawrzynczak, Nick Vaccaro, Srinidhi N Kaushik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45053
to look at the new patch set (#4).
Change subject: mb/google/volteer: Add settings for noise mitgation ......................................................................
mb/google/volteer: Add settings for noise mitgation
Enable acoustic noise mitgation for volteer platforms.
BUG=b:153015585 BRANCH=none TEST= Measure the change in noise level by changing the values in devicetree.
Signed-off-by: Shaunak Saha shaunak.saha@intel.com Change-Id: I69a6453091bf607d3c5847c99bc077e6b7dbc639 --- M src/mainboard/google/volteer/variants/delbin/overridetree.cb M src/mainboard/google/volteer/variants/volteer/overridetree.cb M src/mainboard/google/volteer/variants/volteer2/overridetree.cb 3 files changed, 33 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/45053/4
Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Caveh Jalali, Eric Herrmann, Duncan Laurie, Tim Wawrzynczak, Nick Vaccaro, Srinidhi N Kaushik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45053
to look at the new patch set (#6).
Change subject: mb/google/volteer: Add settings for noise mitgation ......................................................................
mb/google/volteer: Add settings for noise mitgation
Enable acoustic noise mitgation for volteer platforms.
BUG=b:153015585 BRANCH=none TEST= Measure the change in noise level by changing the values in devicetree.
Signed-off-by: Shaunak Saha shaunak.saha@intel.com Change-Id: I69a6453091bf607d3c5847c99bc077e6b7dbc639 --- M src/mainboard/google/volteer/variants/delbin/overridetree.cb M src/mainboard/google/volteer/variants/volteer/overridetree.cb M src/mainboard/google/volteer/variants/volteer2/overridetree.cb 3 files changed, 33 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/45053/6
Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45053 )
Change subject: mb/google/volteer: Add settings for noise mitgation ......................................................................
Patch Set 7: Code-Review+1
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45053 )
Change subject: mb/google/volteer: Add settings for noise mitgation ......................................................................
Patch Set 7: Code-Review+2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45053 )
Change subject: mb/google/volteer: Add settings for noise mitgation ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45053/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/45053/3/src/mainboard/google/voltee... PS3, Line 233: # Acoustic settings : register "AcousticNoiseMitigation" = "1" : register "SlowSlewRate[0]" = "2" : register "SlowSlewRate[1]" = "2" : register "SlowSlewRate[2]" = "2" : register "SlowSlewRate[3]" = "2" : register "FastPkgCRampDisable[0]" = "1" : register "FastPkgCRampDisable[1]" = "1" : register "FastPkgCRampDisable[2]" = "1" : register "FastPkgCRampDisable[3]" = "1" :
Will use these in override cb files.
Ack
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45053 )
Change subject: mb/google/volteer: Add settings for noise mitgation ......................................................................
mb/google/volteer: Add settings for noise mitgation
Enable acoustic noise mitgation for volteer platforms.
BUG=b:153015585 BRANCH=none TEST= Measure the change in noise level by changing the values in devicetree.
Signed-off-by: Shaunak Saha shaunak.saha@intel.com Change-Id: I69a6453091bf607d3c5847c99bc077e6b7dbc639 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45053 Reviewed-by: Duncan Laurie dlaurie@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/delbin/overridetree.cb M src/mainboard/google/volteer/variants/volteer/overridetree.cb M src/mainboard/google/volteer/variants/volteer2/overridetree.cb 3 files changed, 33 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Shaunak Saha: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/volteer/variants/delbin/overridetree.cb b/src/mainboard/google/volteer/variants/delbin/overridetree.cb index 21b1f07..5ecfccf 100644 --- a/src/mainboard/google/volteer/variants/delbin/overridetree.cb +++ b/src/mainboard/google/volteer/variants/delbin/overridetree.cb @@ -2,6 +2,17 @@ register "DdiPort1Hpd" = "0" register "DdiPort2Hpd" = "0"
+ # Acoustic settings + register "AcousticNoiseMitigation" = "1" + register "SlowSlewRate[VR_DOMAIN_IA]" = "SLEW_FAST_8" + register "SlowSlewRate[VR_DOMAIN_GT]" = "SLEW_FAST_8" + register "SlowSlewRate[VR_DOMAIN_SA]" = "SLEW_FAST_8" + register "SlowSlewRate[VR_DOMAIN_VLCC]" = "SLEW_FAST_8" + register "FastPkgCRampDisable[VR_DOMAIN_IA]" = "1" + register "FastPkgCRampDisable[VR_DOMAIN_GT]" = "1" + register "FastPkgCRampDisable[VR_DOMAIN_SA]" = "1" + register "FastPkgCRampDisable[VR_DOMAIN_VLCC]" = "1" + device domain 0 on device ref i2c0 on chip drivers/i2c/generic diff --git a/src/mainboard/google/volteer/variants/volteer/overridetree.cb b/src/mainboard/google/volteer/variants/volteer/overridetree.cb index 2c120d5..c5b4c72 100644 --- a/src/mainboard/google/volteer/variants/volteer/overridetree.cb +++ b/src/mainboard/google/volteer/variants/volteer/overridetree.cb @@ -49,6 +49,17 @@
register "HybridStorageMode" = "1"
+ # Acoustic settings + register "AcousticNoiseMitigation" = "1" + register "SlowSlewRate[VR_DOMAIN_IA]" = "SLEW_FAST_8" + register "SlowSlewRate[VR_DOMAIN_GT]" = "SLEW_FAST_8" + register "SlowSlewRate[VR_DOMAIN_SA]" = "SLEW_FAST_8" + register "SlowSlewRate[VR_DOMAIN_VLCC]" = "SLEW_FAST_8" + register "FastPkgCRampDisable[VR_DOMAIN_IA]" = "1" + register "FastPkgCRampDisable[VR_DOMAIN_GT]" = "1" + register "FastPkgCRampDisable[VR_DOMAIN_SA]" = "1" + register "FastPkgCRampDisable[VR_DOMAIN_VLCC]" = "1" + device domain 0 on device ref ipu on end device ref i2c0 on diff --git a/src/mainboard/google/volteer/variants/volteer2/overridetree.cb b/src/mainboard/google/volteer/variants/volteer2/overridetree.cb index d49a52a..2db1f08 100644 --- a/src/mainboard/google/volteer/variants/volteer2/overridetree.cb +++ b/src/mainboard/google/volteer/variants/volteer2/overridetree.cb @@ -7,6 +7,17 @@
register "HybridStorageMode" = "1"
+ # Acoustic settings + register "AcousticNoiseMitigation" = "1" + register "SlowSlewRate[VR_DOMAIN_IA]" = "SLEW_FAST_8" + register "SlowSlewRate[VR_DOMAIN_GT]" = "SLEW_FAST_8" + register "SlowSlewRate[VR_DOMAIN_SA]" = "SLEW_FAST_8" + register "SlowSlewRate[VR_DOMAIN_VLCC]" = "SLEW_FAST_8" + register "FastPkgCRampDisable[VR_DOMAIN_IA]" = "1" + register "FastPkgCRampDisable[VR_DOMAIN_GT]" = "1" + register "FastPkgCRampDisable[VR_DOMAIN_SA]" = "1" + register "FastPkgCRampDisable[VR_DOMAIN_VLCC]" = "1" + device domain 0 on device ref dptf on chip drivers/intel/dptf
-
Caveh Jalali (Code Review) -
Duncan Laurie (Code Review)
-
Furquan Shaikh (Code Review)
-
Shaunak Saha (Code Review)
-
Tim Wawrzynczak (Code Review)