Attention is currently required from: Martin Roth, Stefan Reinauer, Angel Pons, Arthur Heymans, Patrik Tesarik.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54019 )
Change subject: payloads/Tianocore: Update default build target, simplify build options
......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS1:
do those platforms work with `TIANOCORE_USE_8254_TIMER` selected? If so, could just select that as […]
Done
PS1:
In comparison to Upstream EDK2 there is no UEFI boot menu prompt a la "Select boot option: Shell or OS". Is this to be expected?
I'm not sure what you're referring to here. In upstream master, the prompt is 'F2/Down for Boot Manager; Enter to boot directly.' In my fork Boot Manager is remapped to ESC, and there's no option to skip the timeout via Enter, but I've never seen an option to select Shell or OS, since they are functionally equal as BootOrder entries.
File payloads/external/tianocore/Kconfig:
https://review.coreboot.org/c/coreboot/+/54019/comment/7a875ad9_cecf4881
PS1, Line 22: 9Elements
A bit nitpicky, but it's spelled 9elements actually.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54019
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If545fbd0c30be6dcc6ff43107b80980fa23a527e
Gerrit-Change-Number: 54019
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrik Tesarik
depate@das-labor.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrik Tesarik
depate@das-labor.org
Gerrit-Comment-Date: Tue, 11 May 2021 14:32:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Patrik Tesarik
depate@das-labor.org
Gerrit-MessageType: comment