build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37871 )
Change subject: soc/intel/common/block: Enable PMC IPC driver ......................................................................
Patch Set 13:
(10 comments)
https://review.coreboot.org/c/coreboot/+/37871/13/src/soc/intel/common/block... File src/soc/intel/common/block/include/intelblocks/pmclib.h:
https://review.coreboot.org/c/coreboot/+/37871/13/src/soc/intel/common/block... PS13, Line 257: enum cb_err pmc_send_ipc_cmd(uint32_t *cmd, uint32_t inlen, struct pmc_ipc_buffer *wbuf, struct pmc_ipc_buffer *rbuf); line over 96 characters
https://review.coreboot.org/c/coreboot/+/37871/13/src/soc/intel/common/block... File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/37871/13/src/soc/intel/common/block... PS13, Line 634: enum cb_err pmc_send_ipc_cmd(uint32_t *cmd, uint32_t inlen, struct pmc_ipc_buffer *wbuf, struct pmc_ipc_buffer *rbuf) line over 96 characters
https://review.coreboot.org/c/coreboot/+/37871/13/src/soc/intel/common/block... PS13, Line 638: pmcbase= soc_read_pmc_base(); spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/37871/13/src/soc/intel/common/block... PS13, Line 650: write32((void*)pmcbase + PMC_IPC_CMD_OFFSET, *cmd); "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/37871/13/src/soc/intel/common/block... PS13, Line 654: return CB_ERR; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37871/13/src/soc/intel/common/block... PS13, Line 654: return CB_ERR; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37871/13/src/soc/intel/common/block... PS13, Line 658: rbuf->buf0 = read32((void*)pmcbase + PMC_IPC_RBUF0); "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/37871/13/src/soc/intel/common/block... PS13, Line 659: rbuf->buf1 = read32((void*)pmcbase + PMC_IPC_RBUF1); "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/37871/13/src/soc/intel/common/block... PS13, Line 660: rbuf->buf2 = read32((void*)pmcbase + PMC_IPC_RBUF2); "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/37871/13/src/soc/intel/common/block... PS13, Line 661: rbuf->buf3 = read32((void*)pmcbase + PMC_IPC_RBUF3); "(foo*)" should be "(foo *)"
-
build bot (Jenkins) (Code Review)