Attention is currently required from: Raul Rangel, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74095 )
Change subject: mb/google/myst: First pass GPIO configuration for Myst ......................................................................
Patch Set 13:
(1 comment)
File src/mainboard/google/myst/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/74095/comment/46d2ac53_432cae03 PS11, Line 111: SPI_SOC_DI_FPMCU_DO_R
Why were these updated to `FPMCU`? […]
If you look at the schematic https://ee-schematics.teams.x20web.corp.google.com/myst/myst/proto0/referenc...
The SPI connections are mutually exclusive and can be used for fingerprint or touchscreen. The bug in the TODO is showing that we need to selectively init.
For Myst, fingerprint can be a UART or a SPI variant. Touchscreens can be I2C or SPI, but we have decided not to build devices with SPI enabled touchscreens for our reference. See b/273170012#comment7
In this case both these lines and the lines below are for FPMCU, but depend on which FPMCU we've installed. The touchscreen lines are pulled out to test points and are not actually connected to the SoC.
-
Jon Murphy (Code Review)