Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31530 )
Change subject: drivers/intel/fsp2_0: Update dependency of USE_FSP_REPO
......................................................................
Patch Set 4:
I agree to the change, but just realized that the description
of SOC_INTEL_COMMON_CANNONLAKE_BASE doesn't make much sense
any more, does it?
Still some context SOC_INTEL_COMMON_CANNONLAKE_BASE is applicable. may be you can check CNL code base for that.
Yes, sure. It's just the help text of that Kconfig option; it
seems outdated with the addition of CML. It talks about FSP
header differences of SOC_INTEL_COMMON_CANNONLAKE_BASE and
SOC_INTEL_CANNONLAKE. But with CML, FSP headers differ even
within the group of SOC_INTEL_COMMON_CANNONLAKE_BASE.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31530
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e5d5a9fdf3f5d3e79922e97719e8491aa514cef
Gerrit-Change-Number: 31530
Gerrit-PatchSet: 4
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 24 Feb 2019 22:33:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment