Change in coreboot[master]: acpigen,soc/amd,cpu/intel: rework static DWORD for CPPC table - coreboot-gerrit

5 Oct 2021


      Attention is currently required from:  Felix Singer, Raul Rangel, Furquan Shaikh, Paul Menzel, Angel Pons, Subrata Banik, Kyösti Mälkki, Patrick Rudolph, Jason Glenesk, Matt Delco, Nico Huber, Marshall Dawson, Tim Wawrzynczak, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57886 )
Change subject: acpigen,soc/amd,cpu/intel: rework static DWORD for CPPC table
......................................................................
Patch Set 6:
(108 comments)
File src/cpu/intel/common/common_init.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/d3f6046b_e250a667 
PS6, Line 108: 	config->entries[CPPC_HIGHEST_PERF]		= CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 0, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/5b69bf7f_ceb0c15b 
PS6, Line 108: 	config->entries[CPPC_HIGHEST_PERF]		= CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 0, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/a2274d19_7ac9d59b 
PS6, Line 108: 	config->entries[CPPC_HIGHEST_PERF]		= CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 0, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/b6e72ec3_12e12940 
PS6, Line 109: 	config->entries[CPPC_NOMINAL_PERF]		= CPPC_REG( ACPI_REG_MSR(MSR_PLATFORM_INFO, 8, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/fcdd39e9_c87fb636 
PS6, Line 109: 	config->entries[CPPC_NOMINAL_PERF]		= CPPC_REG( ACPI_REG_MSR(MSR_PLATFORM_INFO, 8, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/e2005d91_7f97c949 
PS6, Line 109: 	config->entries[CPPC_NOMINAL_PERF]		= CPPC_REG( ACPI_REG_MSR(MSR_PLATFORM_INFO, 8, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/dd385975_b82bf28d 
PS6, Line 110: 	config->entries[CPPC_LOWEST_NONL_PERF]		= CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 16, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/937417d4_83d03dd7 
PS6, Line 110: 	config->entries[CPPC_LOWEST_NONL_PERF]		= CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 16, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/c0b3882c_b5bad913 
PS6, Line 110: 	config->entries[CPPC_LOWEST_NONL_PERF]		= CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 16, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/374f40cf_4ae63a28 
PS6, Line 111: 	config->entries[CPPC_LOWEST_PERF]		= CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 24, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/fff05e33_788ad383 
PS6, Line 111: 	config->entries[CPPC_LOWEST_PERF]		= CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 24, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/f8055b63_812c9980 
PS6, Line 111: 	config->entries[CPPC_LOWEST_PERF]		= CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 24, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/e828c8e8_79ea6f6e 
PS6, Line 112: 	config->entries[CPPC_GUARANTEED_PERF]		= CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 8, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/016a5549_64fc5557 
PS6, Line 112: 	config->entries[CPPC_GUARANTEED_PERF]		= CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 8, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/491a4ed5_149ea9a2 
PS6, Line 112: 	config->entries[CPPC_GUARANTEED_PERF]		= CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 8, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/ff482239_37fe7e71 
PS6, Line 113: 	config->entries[CPPC_DESIRED_PERF]		= CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 16, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/f47cbe59_8159b8dd 
PS6, Line 113: 	config->entries[CPPC_DESIRED_PERF]		= CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 16, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/8c1f6ace_afb485ce 
PS6, Line 113: 	config->entries[CPPC_DESIRED_PERF]		= CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 16, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/0801ab46_c8e6e6ea 
PS6, Line 114: 	config->entries[CPPC_MIN_PERF]			= CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 0, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/a5620ee4_9a2e77c6 
PS6, Line 114: 	config->entries[CPPC_MIN_PERF]			= CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 0, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/8872597b_26df6096 
PS6, Line 114: 	config->entries[CPPC_MIN_PERF]			= CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 0, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/ef0559af_be3d13f2 
PS6, Line 115: 	config->entries[CPPC_MAX_PERF]			= CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 8, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/626ea080_0d57c48f 
PS6, Line 115: 	config->entries[CPPC_MAX_PERF]			= CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 8, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/76aa6119_8096da1f 
PS6, Line 115: 	config->entries[CPPC_MAX_PERF]			= CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 8, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/455a9eea_6a12b368 
PS6, Line 116: 	config->entries[CPPC_PERF_REDUCE_TOLERANCE]	= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/20acb776_8d067b5a 
PS6, Line 116: 	config->entries[CPPC_PERF_REDUCE_TOLERANCE]	= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/f4f7dea6_98cb2d17 
PS6, Line 117: 	config->entries[CPPC_TIME_WINDOW]		= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/739d5a70_0c7c9c74 
PS6, Line 117: 	config->entries[CPPC_TIME_WINDOW]		= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/671ecced_06adbb32 
PS6, Line 118: 	config->entries[CPPC_COUNTER_WRAP]		= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/fa705c59_6cc5e271 
PS6, Line 118: 	config->entries[CPPC_COUNTER_WRAP]		= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/888c0a3e_d6184c52 
PS6, Line 119: 	config->entries[CPPC_REF_PERF_COUNTER]		= CPPC_REG( ACPI_REG_MSR(IA32_MPERF, 0, 64) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/296427ca_3153c3ff 
PS6, Line 119: 	config->entries[CPPC_REF_PERF_COUNTER]		= CPPC_REG( ACPI_REG_MSR(IA32_MPERF, 0, 64) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/fb62dc12_cabd57ff 
PS6, Line 119: 	config->entries[CPPC_REF_PERF_COUNTER]		= CPPC_REG( ACPI_REG_MSR(IA32_MPERF, 0, 64) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/b531d3ad_e010f289 
PS6, Line 120: 	config->entries[CPPC_DELIVERED_PERF_COUNTER]	= CPPC_REG( ACPI_REG_MSR(IA32_APERF, 0, 64) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/fbc7b2e6_5e435273 
PS6, Line 120: 	config->entries[CPPC_DELIVERED_PERF_COUNTER]	= CPPC_REG( ACPI_REG_MSR(IA32_APERF, 0, 64) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/6cbcb316_669a4252 
PS6, Line 120: 	config->entries[CPPC_DELIVERED_PERF_COUNTER]	= CPPC_REG( ACPI_REG_MSR(IA32_APERF, 0, 64) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/13f2f180_83b174e0 
PS6, Line 121: 	config->entries[CPPC_PERF_LIMITED]		= CPPC_REG( ACPI_REG_MSR(IA32_HWP_STATUS, 2, 1) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/7331b4af_4ef665ca 
PS6, Line 121: 	config->entries[CPPC_PERF_LIMITED]		= CPPC_REG( ACPI_REG_MSR(IA32_HWP_STATUS, 2, 1) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/7ec4cd59_af86fbea 
PS6, Line 121: 	config->entries[CPPC_PERF_LIMITED]		= CPPC_REG( ACPI_REG_MSR(IA32_HWP_STATUS, 2, 1) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/c961d25e_d81d9477 
PS6, Line 122: 	config->entries[CPPC_ENABLE]			= CPPC_REG( ACPI_REG_MSR(IA32_PM_ENABLE, 0, 1) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/cee5eac5_b26a20e6 
PS6, Line 122: 	config->entries[CPPC_ENABLE]			= CPPC_REG( ACPI_REG_MSR(IA32_PM_ENABLE, 0, 1) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/0b25fb16_0a6f477c 
PS6, Line 122: 	config->entries[CPPC_ENABLE]			= CPPC_REG( ACPI_REG_MSR(IA32_PM_ENABLE, 0, 1) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/cdf9fc0b_19ff8c5c 
PS6, Line 128: 	config->entries[CPPC_AUTO_ACTIVITY_WINDOW]	= CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 32, 10) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/eadb037f_3db95e66 
PS6, Line 128: 	config->entries[CPPC_AUTO_ACTIVITY_WINDOW]	= CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 32, 10) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/cbdda4ca_485e6772 
PS6, Line 128: 	config->entries[CPPC_AUTO_ACTIVITY_WINDOW]	= CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 32, 10) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/441262cf_a8e1c6e5 
PS6, Line 129: 	config->entries[CPPC_PERF_PREF]			= CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 24, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/f2353d5f_bce1b53d 
PS6, Line 129: 	config->entries[CPPC_PERF_PREF]			= CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 24, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/1844d896_95518d17 
PS6, Line 129: 	config->entries[CPPC_PERF_PREF]			= CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 24, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/4d024933_f384d48c 
PS6, Line 130: 	config->entries[CPPC_REF_PERF]			= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/5a64c59b_91978a3f 
PS6, Line 130: 	config->entries[CPPC_REF_PERF]			= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/5673de82_77630a4e 
PS6, Line 135: 	config->entries[CPPC_LOWEST_FREQ]		= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/361bf958_1a0661e4 
PS6, Line 135: 	config->entries[CPPC_LOWEST_FREQ]		= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/6cdcaeaa_fb616c76 
PS6, Line 136: 	config->entries[CPPC_NOMINAL_FREQ]		= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/5c5cc6f8_fa417373 
PS6, Line 136: 	config->entries[CPPC_NOMINAL_FREQ]		= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
File src/soc/amd/cezanne/cppc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/7af7ed12_cfe4cad0 
PS6, Line 18: 	config->entries[CPPC_HIGHEST_PERF]		= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_HIGHEST_PERF, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/39ff52f9_7c01704f 
PS6, Line 18: 	config->entries[CPPC_HIGHEST_PERF]		= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_HIGHEST_PERF, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/3ff02e05_fde7b625 
PS6, Line 18: 	config->entries[CPPC_HIGHEST_PERF]		= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_HIGHEST_PERF, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/2c5eccb6_5f2a2119 
PS6, Line 19: 	config->entries[CPPC_NOMINAL_PERF]		= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_NOMINAL_PERF, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/0e1f7056_d8452bf3 
PS6, Line 19: 	config->entries[CPPC_NOMINAL_PERF]		= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_NOMINAL_PERF, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/da77b7f1_05f3a74a 
PS6, Line 19: 	config->entries[CPPC_NOMINAL_PERF]		= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_NOMINAL_PERF, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/d5b71304_fb172b7a 
PS6, Line 20: 	config->entries[CPPC_LOWEST_NONL_PERF]		= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOW_NON_LIN_PERF, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/caaf9c5a_45a39cb8 
PS6, Line 20: 	config->entries[CPPC_LOWEST_NONL_PERF]		= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOW_NON_LIN_PERF, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/ba8bc04f_2c84ae1f 
PS6, Line 20: 	config->entries[CPPC_LOWEST_NONL_PERF]		= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOW_NON_LIN_PERF, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/7467c198_89c9ea9f 
PS6, Line 21: 	config->entries[CPPC_LOWEST_PERF]		= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOWEST_PERF, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/7b727da8_6496ad4b 
PS6, Line 21: 	config->entries[CPPC_LOWEST_PERF]		= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOWEST_PERF, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/e3595c14_7baa9dbd 
PS6, Line 21: 	config->entries[CPPC_LOWEST_PERF]		= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOWEST_PERF, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/f425b812_6902296e 
PS6, Line 22: 	config->entries[CPPC_GUARANTEED_PERF]		= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/caa6799f_0af9ed01 
PS6, Line 22: 	config->entries[CPPC_GUARANTEED_PERF]		= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/225dbeec_c67ca245 
PS6, Line 23: 	config->entries[CPPC_DESIRED_PERF]		= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_DES_PERF, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/8ba482a3_75ddb917 
PS6, Line 23: 	config->entries[CPPC_DESIRED_PERF]		= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_DES_PERF, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/528af297_bb8fb915 
PS6, Line 23: 	config->entries[CPPC_DESIRED_PERF]		= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_DES_PERF, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/6b830168_1c3112c1 
PS6, Line 24: 	config->entries[CPPC_MIN_PERF]			= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MIN_PERF, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/83947e37_a6d1de77 
PS6, Line 24: 	config->entries[CPPC_MIN_PERF]			= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MIN_PERF, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/5969143e_4123a006 
PS6, Line 24: 	config->entries[CPPC_MIN_PERF]			= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MIN_PERF, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/ea5b2633_68728393 
PS6, Line 25: 	config->entries[CPPC_MAX_PERF]			= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MAX_PERF, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/5f2e779f_87ccd6fa 
PS6, Line 25: 	config->entries[CPPC_MAX_PERF]			= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MAX_PERF, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/a824759b_9d275d74 
PS6, Line 25: 	config->entries[CPPC_MAX_PERF]			= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MAX_PERF, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/2cba71f1_e1a04f41 
PS6, Line 26: 	config->entries[CPPC_PERF_REDUCE_TOLERANCE]	= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/430c2f60_4e86b21f 
PS6, Line 26: 	config->entries[CPPC_PERF_REDUCE_TOLERANCE]	= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/2b110801_2888c126 
PS6, Line 27: 	config->entries[CPPC_TIME_WINDOW]		= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/c8a7660f_86b39852 
PS6, Line 27: 	config->entries[CPPC_TIME_WINDOW]		= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/b11a8111_15387f64 
PS6, Line 28: 	config->entries[CPPC_COUNTER_WRAP]		= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/a83d2d16_83526fc3 
PS6, Line 28: 	config->entries[CPPC_COUNTER_WRAP]		= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/8ae3150a_40e8c4b8 
PS6, Line 29: 	config->entries[CPPC_REF_PERF_COUNTER]		= CPPC_REG( ACPI_REG_MSR(MSR_MAX_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/43a01cf2_1428474d 
PS6, Line 29: 	config->entries[CPPC_REF_PERF_COUNTER]		= CPPC_REG( ACPI_REG_MSR(MSR_MAX_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/decffee2_f47f673c 
PS6, Line 29: 	config->entries[CPPC_REF_PERF_COUNTER]		= CPPC_REG( ACPI_REG_MSR(MSR_MAX_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/eef77ae4_1b382e34 
PS6, Line 30: 	config->entries[CPPC_DELIVERED_PERF_COUNTER]	= CPPC_REG( ACPI_REG_MSR(MSR_ACTUAL_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/f7b3cf82_5ee655bd 
PS6, Line 30: 	config->entries[CPPC_DELIVERED_PERF_COUNTER]	= CPPC_REG( ACPI_REG_MSR(MSR_ACTUAL_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/308abc0b_e704e4f0 
PS6, Line 30: 	config->entries[CPPC_DELIVERED_PERF_COUNTER]	= CPPC_REG( ACPI_REG_MSR(MSR_ACTUAL_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/817df33b_586f54e1 
PS6, Line 31: 	config->entries[CPPC_PERF_LIMITED]		= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_STATUS, 1, 1) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/2ebf736f_46586b44 
PS6, Line 31: 	config->entries[CPPC_PERF_LIMITED]		= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_STATUS, 1, 1) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/1aafe50b_6b7e97ac 
PS6, Line 31: 	config->entries[CPPC_PERF_LIMITED]		= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_STATUS, 1, 1) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/b608a0df_069c3381 
PS6, Line 32: 	config->entries[CPPC_ENABLE]			= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_ENABLE, 0, 1) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/ac45f93a_dfa7d00f 
PS6, Line 32: 	config->entries[CPPC_ENABLE]			= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_ENABLE, 0, 1) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/712e138f_d4cd8527 
PS6, Line 32: 	config->entries[CPPC_ENABLE]			= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_ENABLE, 0, 1) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/cc3fa83a_cb495afe 
PS6, Line 37: 	config->entries[CPPC_AUTO_SELECT]		= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/42fbbf3b_a9d4d058 
PS6, Line 37: 	config->entries[CPPC_AUTO_SELECT]		= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/675f80de_bd70a38b 
PS6, Line 38: 	config->entries[CPPC_AUTO_ACTIVITY_WINDOW]	= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/926983a4_25b1f7af 
PS6, Line 38: 	config->entries[CPPC_AUTO_ACTIVITY_WINDOW]	= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/003d55ca_0d76afb0 
PS6, Line 39: 	config->entries[CPPC_PERF_PREF]			= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_ENERGY_PERF_PREF, 8) );
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/ca2d09fe_ab869eec 
PS6, Line 39: 	config->entries[CPPC_PERF_PREF]			= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_ENERGY_PERF_PREF, 8) );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/dd7cd787_4c514040 
PS6, Line 39: 	config->entries[CPPC_PERF_PREF]			= CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_ENERGY_PERF_PREF, 8) );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/36e6526a_61b8a244 
PS6, Line 40: 	config->entries[CPPC_REF_PERF]			= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/1dfa7e67_9d6069f3 
PS6, Line 40: 	config->entries[CPPC_REF_PERF]			= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/59a595f1_5391428d 
PS6, Line 45: 	config->entries[CPPC_LOWEST_FREQ]		= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/83d1ef69_db070394 
PS6, Line 45: 	config->entries[CPPC_LOWEST_FREQ]		= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/2acced52_bff45497 
PS6, Line 46: 	config->entries[CPPC_NOMINAL_FREQ]		= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129830):
https://review.coreboot.org/c/coreboot/+/57886/comment/ae6f6231_e779c830 
PS6, Line 46: 	config->entries[CPPC_NOMINAL_FREQ]		= CPPC_REG( ACPI_REG_UNSUPPORTED );
space prohibited before that close parenthesis ')'
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/57886
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib853261b5c0ea87ae2424fed188f2d1872be9a06
Gerrit-Change-Number: 57886
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer:  Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt Delco delco@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention:  Felix Singer felixsinger@posteo.net
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik subrata.banik@intel.com
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Matt Delco delco@chromium.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 05 Oct 2021 22:14:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment