Change in coreboot[master]: vc/amd/agesa/f15tn: add 933 MHz to GfxMemClockFrequencyDefinitionTable

[Mike Banon (Code Review)]

Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40485 )

Change subject: vc/amd/agesa/f15tn: add 933 MHz to GfxMemClockFrequencyDefinitionTable
......................................................................

vc/amd/agesa/f15tn: add 933 MHz to GfxMemClockFrequencyDefinitionTable

This fix is required to avoid the division-by-zero error described at
https://mail.coreboot.org/pipermail/coreboot/2014-March/077418.html
while trying to run the DDR3 memory at 1866 MHz frequency (= 2*933).

With this fix in place, ASUS A88XM-E boots fine with RAM at 1866 MHz.

Signed-off-by: Mike Banon 
Change-Id: I8e7d00e362879b1247ecf2ab828936268bf9075f
---
M src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbInitTN/GfxLibTN.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/40485/1

diff --git a/src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbInitTN/GfxLibTN.c b/src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbInitTN/GfxLibTN.c
index ce50a97..6177d08 100644
--- a/src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbInitTN/GfxLibTN.c
+++ b/src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbInitTN/GfxLibTN.c
@@ -73,7 +73,7 @@
 CONST UINT16 GfxMemClockFrequencyDefinitionTable [][8] = {
 {0 ,  0 ,  0 ,  0 ,  333,  0,  400,  0 },
 {0 ,  0 ,  533,  0 ,  0 ,  0 ,  667,  0 },
-{0 ,  0 ,   800,  0 ,  0 ,  0 ,  0 ,  0 },
+{0 ,  0 ,   800,  0 ,  0 ,  0 , 933,  0 },
 {0 , 1050, 1066, 0 , 0,    0 , 0,    1200}
 };

[Michał Żygowski (Code Review)]

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40485 )

Change subject: vc/amd/agesa/f15tn: add 933 MHz to GfxMemClockFrequencyDefinitionTable
......................................................................

Patch Set 1: Code-Review+1

Let's give others some time to test it. Later I can give +2

[Mike Banon (Code Review)]

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40485 )

Change subject: vc/amd/agesa/f15tn: add 933 MHz to GfxMemClockFrequencyDefinitionTable
......................................................................

Patch Set 1:

Bump for this tiny but important change.

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40485 )

Change subject: vc/amd/agesa/f15tn: add 933 MHz to GfxMemClockFrequencyDefinitionTable
......................................................................

Patch Set 1: Code-Review+1

(3 comments)

https://review.coreboot.org/c/coreboot/+/40485/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40485/1//COMMIT_MSG@11 
PS1, Line 11: 1866 MHz frequency (= 2*933).
`1866 MT/s` is the same as `933 MHz`, so this part should be:

1866 MT/s (933 MHz)

https://review.coreboot.org/c/coreboot/+/40485/1//COMMIT_MSG@13 
PS1, Line 13: MHz
MT/s

https://review.coreboot.org/c/coreboot/+/40485/1/src/vendorcode/amd/agesa/f1... 
File src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbInitTN/GfxLibTN.c:

https://review.coreboot.org/c/coreboot/+/40485/1/src/vendorcode/amd/agesa/f1... 
PS1, Line 73: GfxMemClockFrequencyDefinitionTable
How about adding a check to whatever uses this array? If the value is zero, bail out instead of dividing by zero. (please create a separate commit to fix this, though)

[Mike Banon (Code Review)]

Hello build bot (Jenkins), Michał Żygowski, Paul Menzel, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40485

to look at the new patch set (#2).

Change subject: vc/amd/agesa/f15tn: add 933 MHz to GfxMemClockFrequencyDefinitionTable
......................................................................

vc/amd/agesa/f15tn: add 933 MHz to GfxMemClockFrequencyDefinitionTable

This fix is required to avoid the division-by-zero error described at
https://mail.coreboot.org/pipermail/coreboot/2014-March/077418.html
while trying to run the DDR3 memory at 1866 MT/s (933 MHz).

With this fix in place, ASUS A88XM-E boots fine with RAM at 1866 MT/s.

Signed-off-by: Mike Banon 
Change-Id: I8e7d00e362879b1247ecf2ab828936268bf9075f
---
M src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbInitTN/GfxLibTN.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/40485/2

[Mike Banon (Code Review)]

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40485 )

Change subject: vc/amd/agesa/f15tn: add 933 MHz to GfxMemClockFrequencyDefinitionTable
......................................................................

Patch Set 2:

(3 comments)

https://review.coreboot.org/c/coreboot/+/40485/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40485/1//COMMIT_MSG@11 
PS1, Line 11: 1866 MHz frequency (= 2*933).
> `1866 MT/s` is the same as `933 MHz`, so this part should be: […]

Done

https://review.coreboot.org/c/coreboot/+/40485/1//COMMIT_MSG@13 
PS1, Line 13: MHz
> MT/s

Done

https://review.coreboot.org/c/coreboot/+/40485/1/src/vendorcode/amd/agesa/f1... 
File src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbInitTN/GfxLibTN.c:

https://review.coreboot.org/c/coreboot/+/40485/1/src/vendorcode/amd/agesa/f1... 
PS1, Line 73: GfxMemClockFrequencyDefinitionTable
> How about adding a check to whatever uses this array? If the value is zero, bail out instead of divi […]

Will do this tomorrow.

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40485 )

Change subject: vc/amd/agesa/f15tn: add 933 MHz to GfxMemClockFrequencyDefinitionTable
......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/40485/1/src/vendorcode/amd/agesa/f1... 
File src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbInitTN/GfxLibTN.c:

https://review.coreboot.org/c/coreboot/+/40485/1/src/vendorcode/amd/agesa/f1... 
PS1, Line 73: GfxMemClockFrequencyDefinitionTable
> Will do this tomorrow.

Ack

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40485 )

Change subject: vc/amd/agesa/f15tn: add 933 MHz to GfxMemClockFrequencyDefinitionTable
......................................................................

vc/amd/agesa/f15tn: add 933 MHz to GfxMemClockFrequencyDefinitionTable

This fix is required to avoid the division-by-zero error described at
https://mail.coreboot.org/pipermail/coreboot/2014-March/077418.html
while trying to run the DDR3 memory at 1866 MT/s (933 MHz).

With this fix in place, ASUS A88XM-E boots fine with RAM at 1866 MT/s.

Signed-off-by: Mike Banon 
Change-Id: I8e7d00e362879b1247ecf2ab828936268bf9075f
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40485
Reviewed-by: Angel Pons 
Reviewed-by: Michał Żygowski 
Tested-by: build bot (Jenkins) 
---
M src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbInitTN/GfxLibTN.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved
  Michał Żygowski: Looks good to me, but someone else must approve

diff --git a/src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbInitTN/GfxLibTN.c b/src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbInitTN/GfxLibTN.c
index ce50a97..6177d08 100644
--- a/src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbInitTN/GfxLibTN.c
+++ b/src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbInitTN/GfxLibTN.c
@@ -73,7 +73,7 @@
 CONST UINT16 GfxMemClockFrequencyDefinitionTable [][8] = {
 {0 ,  0 ,  0 ,  0 ,  333,  0,  400,  0 },
 {0 ,  0 ,  533,  0 ,  0 ,  0 ,  667,  0 },
-{0 ,  0 ,   800,  0 ,  0 ,  0 ,  0 ,  0 },
+{0 ,  0 ,   800,  0 ,  0 ,  0 , 933,  0 },
 {0 , 1050, 1066, 0 , 0,    0 , 0,    1200}
 };