Attention is currently required from: Johnny Lin, Angel Pons, Tim Chu.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68685 )
Change subject: drivers/ipmi/ipmi_kcs_ops.c: accomodate BMC revision being 0
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161192):
https://review.coreboot.org/c/coreboot/+/68685/comment/1afa42ac_91516958
PS2, Line 9: BMC major/minor revision may be 0. Get the value directly from
'accomodate' may be misspelled - perhaps 'accommodate'?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68685
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e08c6d02de8f6efceb69b6d6cebad9d61cfd20e
Gerrit-Change-Number: 68685
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Angel Pons
angel.pons@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Mon, 24 Oct 2022 21:23:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment