Attention is currently required from: Nico Huber, Sridhar Siricilla, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61380 )
Change subject: soc/intel/common: Add support to control coreboot and Intel SoC features
......................................................................
Patch Set 14:
(1 comment)
File src/soc/intel/common/basecode/debug/debug_feature.c:
https://review.coreboot.org/c/coreboot/+/61380/comment/22d7e961_6a825848
PS14, Line 22: pre_mem_debug_init
This is init function of the runtime debug driver. so, I will maintain debug_ as prefix when new helper functions are added to this file. Make sense?
Sure, there is no hard bound that we need to maintain `debug_` across but just thought of floating this idea.
Example: https://github.com/coreboot/coreboot/blob/master/src/soc/intel/common/block/...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61380
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ba40926bd9ad909654f152e48cdd648b28afd62
Gerrit-Change-Number: 61380
Gerrit-PatchSet: 14
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 10 Mar 2022 11:32:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment