Attention is currently required from: Eran Mitrani, Eric Lai, Kapil Porwal, Paul Menzel, Ravishankar Sarawadi, Tarun.
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78252?usp=email )
Change subject: soc/intel/meteorlake: Reserve IOE P2SB MMIO correctly
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78252/comment/5a7f032a_96505cf8 :
PS2, Line 10: code requires
… code that requires …?
Done
https://review.coreboot.org/c/coreboot/+/78252/comment/7442d190_3bb097a6 :
PS2, Line 11: insrc/soc/intel/common/acpi/pcie_clk.asl
Missing space after *in*.
Done
https://review.coreboot.org/c/coreboot/+/78252/comment/7db91648_9079b8a0 :
PS2, Line 13: TEST=suspend_stress_test 50 cycle pass, type-c display OK on screebo
Did it also succeed before your change?
yes, i just wanted to make sure no regression.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78252?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie55f7975277b390f776e44596c42e426ba9cd235
Gerrit-Change-Number: 78252
Gerrit-PatchSet: 3
Gerrit-Owner: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Thu, 05 Oct 2023 11:51:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment