[L] Change in coreboot[main]: [WIP] OptiPlex 3050 port

[Máté Kukri (Code Review)]

Attention is currently required from: Angel Pons, Felix Singer.

Máté Kukri has posted comments on this change by Máté Kukri. ( https://review.coreboot.org/c/coreboot/+/82053?usp=email )

Change subject: [WIP] OptiPlex 3050 port
......................................................................

Patch Set 11:

(4 comments)

File src/mainboard/dell/optiplex_3050/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/82053/comment/13991d91_3a3baf1d?usp... :
PS9, Line 41: 		# Host bridge
            :
> Equals to chipset devicetree, remove

Done

https://review.coreboot.org/c/coreboot/+/82053/comment/13101a7e_25c4de16?usp... :
PS9, Line 44: 		# Intel iGPU
> These comments just repeat the device name, no? Seems superfluous to me.

Yep, removed, this port originally used numeric device IDs and the comments were leftovers.

https://review.coreboot.org/c/coreboot/+/82053/comment/72e5fb09_384eb4f6?usp... :
PS9, Line 87: register "SataPortsEnable" = "{
            : 			       [0] = 1,
            : 			}"
>

Done

File src/mainboard/dell/optiplex_3050/gma-mainboard.ads:

https://review.coreboot.org/c/coreboot/+/82053/comment/d3f3393e_3fd49dc6?usp... :
PS1, Line 15: 		 eDP,		-- eDP	- VGA via RTD2168 (Doesn't seem to work)
> Indent with 3 spaces please […]

Done