Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27276 )
Change subject: soc/amd/common: Remove redundant ACPI S3 test ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/27276/4/src/soc/amd/stoneyridge/Kconfig File src/soc/amd/stoneyridge/Kconfig:
https://review.coreboot.org/#/c/27276/4/src/soc/amd/stoneyridge/Kconfig@a53 PS4, Line 53:
I'm OK with this change. No change in compile time (see the makefile).
I don't remember the details now.. Was it so that Merlin Falcon (from CarrizoPI) could still do 'fastboot from MRC cache'? The code this guards (s3_resume.c) is not only for ACPI S3 so I expect to see some more changes here, i.e. the HAVE_ACPI_RESUME guard is not quite right.
Also, I plan to reuse that s3_resume.c with improved stage_cache and mrc_cache code with agesa/family16 that definetly can do fastboot but is currently not so clean implementation.
-
Kyösti Mälkki (Code Review)