Change in ...coreboot[master]: ec/kontron: Add support for Kontron kempld - coreboot-gerrit

15 Jan 2019


      build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29476 )
Change subject: ec/kontron: Add support for Kontron kempld
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/29476/2/src/ec/kontron/kempld/kempld_i2c.c 
File src/ec/kontron/kempld/kempld_i2c.c:
https://review.coreboot.org/#/c/29476/2/src/ec/kontron/kempld/kempld_i2c.c@1... 
PS2, Line 169: 			} else {
else is not generally useful after a break or return
https://review.coreboot.org/#/c/29476/2/src/ec/kontron/kempld/kempld_i2c.c@2... 
PS2, Line 214: 				printk(BIOS_SPEW, "kempld_i2c: Processed %zu segments.\n", num);
line over 80 characters
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29476
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If9a0826c4a8f5c8cd573610c2d10561334258b36
Gerrit-Change-Number: 29476
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 15 Jan 2019 13:31:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment