Attention is currently required from: Hung-Te Lin, Rex-BC Chen.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58837 )
Change subject: soc/mediatek/mt8186: Add NOR-Flash support
......................................................................
Patch Set 3:
(1 comment)
File src/soc/mediatek/mt8186/Kconfig:
https://review.coreboot.org/c/coreboot/+/58837/comment/40a98af1_dce6bb2b
PS3, Line 19: config FLASH_DUAL_READ
i guess this is about the dual io read mode? if that's the case, maybe rename this to FLASH_DUAL_IO_READ, since that makes it at least for me clearer what this is about. or instead change it the help text to "dual IO read mode"? it's the same on all other existing mediatek socs, so i'll submit this patch as it is right now, but might be good to address this for all mediatek socs in a follow-up commit
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58837
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If51d765e1fd4895f97898710ec6fa1374e1048fb
Gerrit-Change-Number: 58837
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Thu, 04 Nov 2021 01:56:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment