[L] Change in coreboot[master]: soc/intel/{adl, common}: provide a list of D-states to enter LPM
Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal.
Eran Mitrani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70166 )
Change subject: soc/intel/{adl, common}: provide a list of D-states to enter LPM ......................................................................
Patch Set 12:
(6 comments)
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/70166/comment/c21f9880_9ade67e0 PS9, Line 31: LPI_REVISION_0
We should set explicit values for these in the enums. […]
I removed the explicit values per Subrata's comment..
https://review.coreboot.org/c/coreboot/+/70166/comment/f6817c90_14605613 PS9, Line 35: LPI_DISANBLED,
LPI_DISABLED
Done
https://review.coreboot.org/c/coreboot/+/70166/comment/7599c56b_cee69e92 PS9, Line 458: states_arr
This check can be moved to the place where the variable `states_arr` is being used i.e. […]
Done
https://review.coreboot.org/c/coreboot/+/70166/comment/74b375cd_d074057f PS9, Line 467: NONE
`ACPI_DEVICE_SLEEP_NONE`?
Done
https://review.coreboot.org/c/coreboot/+/70166/comment/d3610756_cba80007 PS9, Line 479: return the number of devices included
it seems we aren't returning anything
Done
https://review.coreboot.org/c/coreboot/+/70166/comment/d50c1202_cf075068 PS9, Line 493: acpi_gen_default_lpi_constraints();
I think this can be cleaned up. If we are returning, we don't need the else.
Done
-
Eran Mitrani (Code Review)