Change in coreboot[master]: mb/system76/addw1: Add System76 Adder Workstation 1 - coreboot-gerrit

24 Sep 2021


      Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48421 )
Change subject: mb/system76/addw1: Add System76 Adder Workstation 1
......................................................................
Patch Set 21:
(1 comment)
File src/mainboard/system76/addw1/variants/addw1/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48421/comment/40cb8058_c013ba70 
PS20, Line 5: PchSerialIoPci
...
PchSerialIoSkipInit requires CML, but addw1 is CFL.
I wonder why CFL FSP doesn't have SkipInit, KBL and CML do
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/48421
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5dd3bc320ca640728e1d86180c6bfa0dc7295760
Gerrit-Change-Number: 48421
Gerrit-PatchSet: 21
Gerrit-Owner: Tim Crawford tcrawford@system76.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jeremy Soller jeremy@system76.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Comment-Date: Fri, 24 Sep 2021 11:24:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Crawford tcrawford@system76.com
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment