HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41303 )
Change subject: mb/google/reef: Remove direct 'include <soc/gpio.h>' ......................................................................
mb/google/reef: Remove direct 'include <soc/gpio.h>'
Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>.
Change-Id: I1f351825013c2476936a31c18ae880515b1093e7 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/reef/bootblock.c M src/mainboard/google/reef/chromeos.c M src/mainboard/google/reef/mainboard.c M src/mainboard/google/reef/smihandler.c M src/mainboard/google/reef/variants/coral/mainboard.c 5 files changed, 3 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/41303/1
diff --git a/src/mainboard/google/reef/bootblock.c b/src/mainboard/google/reef/bootblock.c index 3e9f51a..4c6eb68 100644 --- a/src/mainboard/google/reef/bootblock.c +++ b/src/mainboard/google/reef/bootblock.c @@ -4,7 +4,7 @@ #include <bootblock_common.h> #include <ec/ec.h> #include <intelblocks/lpc_lib.h> -#include <soc/gpio.h> +#include <gpio.h> #include <variant/ec.h>
void bootblock_mainboard_init(void) diff --git a/src/mainboard/google/reef/chromeos.c b/src/mainboard/google/reef/chromeos.c index 94d76b9..8b7553d 100644 --- a/src/mainboard/google/reef/chromeos.c +++ b/src/mainboard/google/reef/chromeos.c @@ -4,7 +4,6 @@ #include <boot/coreboot_tables.h> #include <gpio.h> #include <vendorcode/google/chromeos/chromeos.h> -#include <soc/gpio.h> #include <variant/gpio.h>
void fill_lb_gpios(struct lb_gpios *gpios) diff --git a/src/mainboard/google/reef/mainboard.c b/src/mainboard/google/reef/mainboard.c index ebfb311..0b86b9b 100644 --- a/src/mainboard/google/reef/mainboard.c +++ b/src/mainboard/google/reef/mainboard.c @@ -9,7 +9,6 @@ #include <gpio.h> #include <nhlt.h> #include <smbios.h> -#include <soc/gpio.h> #include <soc/nhlt.h> #include <stdio.h> #include <vendorcode/google/chromeos/chromeos.h> diff --git a/src/mainboard/google/reef/smihandler.c b/src/mainboard/google/reef/smihandler.c index 3ca7d10..b611bdf 100644 --- a/src/mainboard/google/reef/smihandler.c +++ b/src/mainboard/google/reef/smihandler.c @@ -6,7 +6,7 @@ #include <ec/google/chromeec/smm.h> #include <intelblocks/smihandler.h> #include <soc/pm.h> -#include <soc/gpio.h> +#include <gpio.h> #include <variant/ec.h> #include <variant/gpio.h>
diff --git a/src/mainboard/google/reef/variants/coral/mainboard.c b/src/mainboard/google/reef/variants/coral/mainboard.c index 683624c..bbc5626 100644 --- a/src/mainboard/google/reef/variants/coral/mainboard.c +++ b/src/mainboard/google/reef/variants/coral/mainboard.c @@ -6,7 +6,7 @@ #include "baseboard/variants.h" #include <soc/cpu.h> #include <soc/intel/apollolake/chip.h> -#include <soc/gpio.h> +#include <gpio.h>
enum { SKU_0_ASTRONAUT = 0,
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41303 )
Change subject: mb/google/reef: Remove direct 'include <soc/gpio.h>' ......................................................................
Abandoned
see #41324