Attention is currently required from: Julius Werner, Raul Rangel.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/82687?usp=email )
Change subject: libpayload: Include libpayload-config.h in lib target ......................................................................
Patch Set 1:
(1 comment)
File payloads/libpayload/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/82687/comment/606d3961_f8cf0f51?usp... : PS1, Line 118: $(obj)/libpayload.ldscript: arch/$(ARCHDIR-y)/libpayload.ldscript
I think you still need to declare `$(obj)/libpayload-config.h` as a dependency here. The `CFLAGS` have `-include include/kconfig.h`, and `kconfig.h` has `#include <libpayload-config.h>`
`#include <libpayload-config.h>` is not only dependency for `$(obj)/libpayload-config.h` but it also expects `$(obj)/libpayload-config.h` to be copied into $(DESTDIR)/libpayload/include (`install -m 644 $(obj)/libpayload-config.h $(DESTDIR)/libpayload/include`), which would anyway happen with line#138.
-
Subrata Banik (Code Review)