Attention is currently required from: Angel Pons, Piotr Król.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67940 )
Change subject: mb/protectli/vault_cml: Add Comet Lake 6 port board support
......................................................................
Patch Set 12:
(1 comment)
File src/mainboard/protectli/vault_cml/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/67940/comment/0eb0b58c_3b74ec6b
PS7, Line 287: device pci 1f.1 on end # P2SB
: device pci 1f.2 on end # Power Management Controller
There are some hardware differences between Sunrise/Union Point (SPT is 100 series PCHs, UPT is 200 […]
Marked them both as hidden. Is that fine for you?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67940
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If1b4f9c8245a082ff875ae9c6102a1c45e677d0b
Gerrit-Change-Number: 67940
Gerrit-PatchSet: 12
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Comment-Date: Tue, 04 Oct 2022 11:19:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment