Change in coreboot[master]: superio/Makefiles: Clean up non-existing directory inclusion
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44317 )
Change subject: superio/Makefiles: Clean up non-existing directory inclusion ......................................................................
superio/Makefiles: Clean up non-existing directory inclusion
Change-Id: I080f5b67c6e555fcc025ec11a1d15dddfe3a546d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/Makefile.inc M src/superio/fintek/Makefile.inc M src/superio/ite/Makefile.inc M src/superio/nsc/Makefile.inc M src/superio/smsc/Makefile.inc M src/superio/winbond/Makefile.inc 6 files changed, 0 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/44317/1
diff --git a/src/superio/Makefile.inc b/src/superio/Makefile.inc index 2b52ca4..e874f34 100644 --- a/src/superio/Makefile.inc +++ b/src/superio/Makefile.inc @@ -2,14 +2,12 @@
subdirs-y += aspeed subdirs-y += fintek -subdirs-y += intel subdirs-y += ite subdirs-y += nsc subdirs-y += nuvoton subdirs-y += renesas subdirs-y += serverengines subdirs-y += smsc -subdirs-y += via subdirs-y += winbond
ramstage-$(CONFIG_ARCH_RAMSTAGE_X86_32) += common/conf_mode.c diff --git a/src/superio/fintek/Makefile.inc b/src/superio/fintek/Makefile.inc index 3d11d29..1c34f6d 100644 --- a/src/superio/fintek/Makefile.inc +++ b/src/superio/fintek/Makefile.inc @@ -4,13 +4,11 @@ bootblock-$(CONFIG_SUPERIO_FINTEK_COMMON_PRE_RAM) += common/early_serial.c romstage-$(CONFIG_SUPERIO_FINTEK_COMMON_PRE_RAM) += common/early_serial.c
-subdirs-y += f71805f subdirs-y += f71808a subdirs-y += f71859 subdirs-y += f71863fg subdirs-y += f71869ad subdirs-y += f71872 -subdirs-y += f81216h subdirs-y += f81865f subdirs-y += f81866d subdirs-y += f81803a diff --git a/src/superio/ite/Makefile.inc b/src/superio/ite/Makefile.inc index f2ebda0..8ff122b 100644 --- a/src/superio/ite/Makefile.inc +++ b/src/superio/ite/Makefile.inc @@ -10,9 +10,7 @@ subdirs-y += it8528e subdirs-y += it8613e subdirs-y += it8623e -subdirs-y += it8671f subdirs-y += it8712f -subdirs-y += it8716f subdirs-y += it8718f subdirs-y += it8720f subdirs-y += it8721f diff --git a/src/superio/nsc/Makefile.inc b/src/superio/nsc/Makefile.inc index 1b5c395..2419e47 100644 --- a/src/superio/nsc/Makefile.inc +++ b/src/superio/nsc/Makefile.inc @@ -4,11 +4,7 @@ bootblock-$(CONFIG_SUPERIO_NSC_COMMON_PRE_RAM) += common/early_serial.c romstage-$(CONFIG_SUPERIO_NSC_COMMON_PRE_RAM) += common/early_serial.c
-subdirs-y += pc87309 -subdirs-y += pc87360 -subdirs-y += pc87366 subdirs-y += pc87382 subdirs-y += pc87384 subdirs-y += pc87392 subdirs-y += pc87417 -subdirs-y += pc97317 diff --git a/src/superio/smsc/Makefile.inc b/src/superio/smsc/Makefile.inc index 9442a9e..86cf9c5 100644 --- a/src/superio/smsc/Makefile.inc +++ b/src/superio/smsc/Makefile.inc @@ -1,9 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only
-subdirs-y += dme1737 subdirs-y += fdc37n972 -subdirs-y += lpc47b272 -subdirs-y += lpc47b397 subdirs-y += lpc47m10x subdirs-y += lpc47m15x subdirs-y += lpc47n207 @@ -15,5 +12,4 @@ subdirs-y += mec1308 subdirs-y += smscsuperio subdirs-y += sio1036 -subdirs-y += sch4037 subdirs-y += sch5545 diff --git a/src/superio/winbond/Makefile.inc b/src/superio/winbond/Makefile.inc index f6b9d57..68c4142 100644 --- a/src/superio/winbond/Makefile.inc +++ b/src/superio/winbond/Makefile.inc @@ -10,6 +10,4 @@ subdirs-y += w83627thg subdirs-y += w83627uhg subdirs-y += w83667hg-a -subdirs-y += w83697hf subdirs-y += w83977tf -subdirs-y += wpcd376i
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44317 )
Change subject: superio/Makefiles: Clean up non-existing directory inclusion ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/44317/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44317/1//COMMIT_MSG@7 PS1, Line 7: Clean up nit: use `Drop` or `Remove` instead?
https://review.coreboot.org/c/coreboot/+/44317/1//COMMIT_MSG@7 PS1, Line 7: superio/Makefiles superio/*/Makefile.inc
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, Arthur Heymans, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44317
to look at the new patch set (#2).
Change subject: superio/*/Makefiles: Remove non-existing directory inclusion ......................................................................
superio/*/Makefiles: Remove non-existing directory inclusion
Change-Id: I080f5b67c6e555fcc025ec11a1d15dddfe3a546d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/Makefile.inc M src/superio/fintek/Makefile.inc M src/superio/ite/Makefile.inc M src/superio/nsc/Makefile.inc M src/superio/smsc/Makefile.inc M src/superio/winbond/Makefile.inc 6 files changed, 0 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/44317/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44317 )
Change subject: superio/*/Makefiles: Remove non-existing directory inclusion ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44317/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44317/1//COMMIT_MSG@7 PS1, Line 7: Clean up
nit: use `Drop` or `Remove` instead?
Done
https://review.coreboot.org/c/coreboot/+/44317/1//COMMIT_MSG@7 PS1, Line 7: superio/Makefiles
superio/*/Makefile. […]
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44317 )
Change subject: superio/*/Makefiles: Remove non-existing directory inclusion ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44317/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44317/2//COMMIT_MSG@7 PS2, Line 7: Makefiles Makefile.inc
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44317 )
Change subject: superio/*/Makefiles: Remove non-existing directory inclusion ......................................................................
superio/*/Makefiles: Remove non-existing directory inclusion
Change-Id: I080f5b67c6e555fcc025ec11a1d15dddfe3a546d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/44317 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/superio/Makefile.inc M src/superio/fintek/Makefile.inc M src/superio/ite/Makefile.inc M src/superio/nsc/Makefile.inc M src/superio/smsc/Makefile.inc M src/superio/winbond/Makefile.inc 6 files changed, 0 insertions(+), 16 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/superio/Makefile.inc b/src/superio/Makefile.inc index 2b52ca4..e874f34 100644 --- a/src/superio/Makefile.inc +++ b/src/superio/Makefile.inc @@ -2,14 +2,12 @@
subdirs-y += aspeed subdirs-y += fintek -subdirs-y += intel subdirs-y += ite subdirs-y += nsc subdirs-y += nuvoton subdirs-y += renesas subdirs-y += serverengines subdirs-y += smsc -subdirs-y += via subdirs-y += winbond
ramstage-$(CONFIG_ARCH_RAMSTAGE_X86_32) += common/conf_mode.c diff --git a/src/superio/fintek/Makefile.inc b/src/superio/fintek/Makefile.inc index 3d11d29..1c34f6d 100644 --- a/src/superio/fintek/Makefile.inc +++ b/src/superio/fintek/Makefile.inc @@ -4,13 +4,11 @@ bootblock-$(CONFIG_SUPERIO_FINTEK_COMMON_PRE_RAM) += common/early_serial.c romstage-$(CONFIG_SUPERIO_FINTEK_COMMON_PRE_RAM) += common/early_serial.c
-subdirs-y += f71805f subdirs-y += f71808a subdirs-y += f71859 subdirs-y += f71863fg subdirs-y += f71869ad subdirs-y += f71872 -subdirs-y += f81216h subdirs-y += f81865f subdirs-y += f81866d subdirs-y += f81803a diff --git a/src/superio/ite/Makefile.inc b/src/superio/ite/Makefile.inc index f2ebda0..8ff122b 100644 --- a/src/superio/ite/Makefile.inc +++ b/src/superio/ite/Makefile.inc @@ -10,9 +10,7 @@ subdirs-y += it8528e subdirs-y += it8613e subdirs-y += it8623e -subdirs-y += it8671f subdirs-y += it8712f -subdirs-y += it8716f subdirs-y += it8718f subdirs-y += it8720f subdirs-y += it8721f diff --git a/src/superio/nsc/Makefile.inc b/src/superio/nsc/Makefile.inc index 1b5c395..2419e47 100644 --- a/src/superio/nsc/Makefile.inc +++ b/src/superio/nsc/Makefile.inc @@ -4,11 +4,7 @@ bootblock-$(CONFIG_SUPERIO_NSC_COMMON_PRE_RAM) += common/early_serial.c romstage-$(CONFIG_SUPERIO_NSC_COMMON_PRE_RAM) += common/early_serial.c
-subdirs-y += pc87309 -subdirs-y += pc87360 -subdirs-y += pc87366 subdirs-y += pc87382 subdirs-y += pc87384 subdirs-y += pc87392 subdirs-y += pc87417 -subdirs-y += pc97317 diff --git a/src/superio/smsc/Makefile.inc b/src/superio/smsc/Makefile.inc index 9442a9e..86cf9c5 100644 --- a/src/superio/smsc/Makefile.inc +++ b/src/superio/smsc/Makefile.inc @@ -1,9 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only
-subdirs-y += dme1737 subdirs-y += fdc37n972 -subdirs-y += lpc47b272 -subdirs-y += lpc47b397 subdirs-y += lpc47m10x subdirs-y += lpc47m15x subdirs-y += lpc47n207 @@ -15,5 +12,4 @@ subdirs-y += mec1308 subdirs-y += smscsuperio subdirs-y += sio1036 -subdirs-y += sch4037 subdirs-y += sch5545 diff --git a/src/superio/winbond/Makefile.inc b/src/superio/winbond/Makefile.inc index f6b9d57..68c4142 100644 --- a/src/superio/winbond/Makefile.inc +++ b/src/superio/winbond/Makefile.inc @@ -10,6 +10,4 @@ subdirs-y += w83627thg subdirs-y += w83627uhg subdirs-y += w83667hg-a -subdirs-y += w83697hf subdirs-y += w83977tf -subdirs-y += wpcd376i
-
Angel Pons (Code Review) -
Felix Held (Code Review)
-
HAOUAS Elyes (Code Review)