Change in coreboot[master]: drivers/intel/fsp2_0: Add FSP 2.2 specific support

[Nathaniel L Desimone (Code Review)]

Nathaniel L Desimone has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41728 )

Change subject: drivers/intel/fsp2_0: Add FSP 2.2 specific support
......................................................................

Patch Set 6:

(2 comments)

https://review.coreboot.org/c/coreboot/+/41728/3/src/drivers/intel/fsp2_0/Kc... 
File src/drivers/intel/fsp2_0/Kconfig:

https://review.coreboot.org/c/coreboot/+/41728/3/src/drivers/intel/fsp2_0/Kc... 
PS3, Line 44: config FSPS_ARCH_UPD
            : 	bool
            : 	depends on HAVE_FSPS_ARCH_UPD
            : 	default y
            : 	help
            : 	  Select this option to use Intel FSP-S Architecture UPDs from FspsUpd.h.
I don't see this used anywhere. Do we really need it? Seems a little redundant with HAVE_FSPS_ARCH_UPD.

https://review.coreboot.org/c/coreboot/+/41728/3/src/drivers/intel/fsp2_0/si... 
File src/drivers/intel/fsp2_0/silicon_init.c:

https://review.coreboot.org/c/coreboot/+/41728/3/src/drivers/intel/fsp2_0/si... 
PS3, Line 136: multi_phase_si_init
It is optional for the FSP to implement multi_phase_si_init() per FSP 2.2 spec. You need to check if this is == NULL and if it is only use silicon_init().