EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33954 )
Change subject: mb/google/hatch/variants: Touch pad no function ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/33954/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/33954/1/src/mainboard/google/hatch/variants/... PS1, Line 98: register "gpio_pm[COMM_0]" = "0" change in board level override
https://review.coreboot.org/#/c/33954/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/33954/1/src/mainboard/google/hatch/variants/... PS1, Line 62: PAD_CFG_GPI_APIC(GPP_A21, NONE, PLTRST, LEVEL, NONE), you should change in board level gpio.c
-
EricR Lai (Code Review)