Hello Zheng Bao, Zheng Bao,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/42220
to review the following change.
Change subject: amd/picasso: set EXTINT on BSP only ......................................................................
amd/picasso: set EXTINT on BSP only
Tested on mandolin board, the error in dmesg "do_IRQ: 1.55 No irq handler for vector" has gone.
Change-Id: I38ed0abbdf9626a5fe96902fc8bcbb1d1b8aac31 Signed-off-by: Zheng Bao zheng.bao@amd.com Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/picasso/Kconfig 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/42220/1
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index e3d145d..003be94 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -367,6 +367,11 @@ help Select this item to enable secure debug options in PSP.
+config LAPIC_EXTINT_ON_BSP_ONLY + def_bool y + help + Only set flag EXTINT on BSP. + endmenu
endif # SOC_AMD_PICASSO
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42220 )
Change subject: amd/picasso: set EXTINT on BSP only ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42220/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42220/1//COMMIT_MSG@11 PS1, Line 11: has gone. Please mention the used payload.
Bao Zheng has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42220 )
Change subject: amd/picasso: set EXTINT on BSP only ......................................................................
Abandoned
It is a x86 generic issue. So the kconfig option is not needed.