Change in coreboot[master]: mb/supermicro/x11ssh: simplify variant mechanism

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35443 )

Change subject: mb/supermicro/x11ssh: simplify variant mechanism
......................................................................

mb/supermicro/x11ssh: simplify variant mechanism

The concept of a "baseboard" does not really make sense for retrofit
coreboot ports. Also, correct the naming of some symbols and values.

Change-Id: If64debe0dda6b32886f5288a6fe918b47c9dcd34
Signed-off-by: Angel Pons 
---
M src/mainboard/supermicro/x11ssh/Kconfig
M src/mainboard/supermicro/x11ssh/Kconfig.name
2 files changed, 7 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/35443/1

diff --git a/src/mainboard/supermicro/x11ssh/Kconfig b/src/mainboard/supermicro/x11ssh/Kconfig
index 4f18a80..4c21986 100644
--- a/src/mainboard/supermicro/x11ssh/Kconfig
+++ b/src/mainboard/supermicro/x11ssh/Kconfig
@@ -1,4 +1,6 @@
-config BOARD_SUPERMICRO_BASEBOARD_X11SSH
+if BOARD_SUPERMICRO_X11SSH_TF
+
+config BOARD_SPECIFIC_OPTIONS
    def_bool n
    select BOARD_ROMSIZE_KB_16384
    select HAVE_ACPI_RESUME
@@ -12,8 +14,6 @@
    select GENERATE_SMBIOS_TABLES
    select IPMI_KCS

-if BOARD_SUPERMICRO_BASEBOARD_X11SSH
-
 config VBOOT
    select VBOOT_NO_BOARD_SUPPORT
    select GBB_FLAG_DISABLE_LID_SHUTDOWN
@@ -46,7 +46,7 @@

config VARIANT_DIR
    string
-	default "tf" if BOARD_SUPERMICRO_X11SSH_PLUS_TF
+	default "tf" if BOARD_SUPERMICRO_X11SSH_TF

config DEVICETREE
    string
@@ -54,7 +54,7 @@

config MAINBOARD_PART_NUMBER
    string
-	default "X11SSH-TF" if BOARD_SUPERMICRO_X11SSH_PLUS_TF
+	default "X11SSH-TF" if BOARD_SUPERMICRO_X11SSH_TF

config MAX_CPUS
    int
diff --git a/src/mainboard/supermicro/x11ssh/Kconfig.name b/src/mainboard/supermicro/x11ssh/Kconfig.name
index a9b351b..fe3bf71 100644
--- a/src/mainboard/supermicro/x11ssh/Kconfig.name
+++ b/src/mainboard/supermicro/x11ssh/Kconfig.name
@@ -1,3 +1,2 @@
-config BOARD_SUPERMICRO_X11SSH_PLUS_TF
-	bool "X11SSH+-TF"
-	select BOARD_SUPERMICRO_BASEBOARD_X11SSH
+config BOARD_SUPERMICRO_X11SSH_TF
+	bool "X11SSH-TF"

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35443 )

Change subject: mb/supermicro/x11ssh: simplify variant mechanism
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35443/1/src/mainboard/supermicro/x1... 
File src/mainboard/supermicro/x11ssh/Kconfig:

https://review.coreboot.org/c/coreboot/+/35443/1/src/mainboard/supermicro/x1... 
PS1, Line 4: n
grml

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35443 )

Change subject: mb/supermicro/x11ssh: simplify variant mechanism
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35443/1/src/mainboard/supermicro/x1... 
File src/mainboard/supermicro/x11ssh/Kconfig:

https://review.coreboot.org/c/coreboot/+/35443/1/src/mainboard/supermicro/x1... 
PS1, Line 4: n
> grml

no, not grml but "y" :P

[Angel Pons (Code Review)]

Hello Michael Niewöhner, Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35443

to look at the new patch set (#2).

Change subject: mb/supermicro/x11ssh: simplify variant mechanism
......................................................................

mb/supermicro/x11ssh: simplify variant mechanism

The concept of a "baseboard" does not really make sense for retrofit
coreboot ports. Also, correct the naming of some symbols and values.

Change-Id: If64debe0dda6b32886f5288a6fe918b47c9dcd34
Signed-off-by: Angel Pons 
---
M src/mainboard/supermicro/x11ssh/Kconfig
M src/mainboard/supermicro/x11ssh/Kconfig.name
2 files changed, 8 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/35443/2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35443 )

Change subject: mb/supermicro/x11ssh: simplify variant mechanism
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35443/1/src/mainboard/supermicro/x1... 
File src/mainboard/supermicro/x11ssh/Kconfig:

https://review.coreboot.org/c/coreboot/+/35443/1/src/mainboard/supermicro/x1... 
PS1, Line 4: n
> no, not grml but "y" :P

It means this: https://grml.org/faq/#whatmeans

Anyway, fixed.

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35443 )

Change subject: mb/supermicro/x11ssh: simplify variant mechanism
......................................................................

Patch Set 2:

(1 comment)
> Patch Set 2:
>
> (1 comment)

https://review.coreboot.org/c/coreboot/+/35443/1/src/mainboard/supermicro/x1... 
File src/mainboard/supermicro/x11ssh/Kconfig:

https://review.coreboot.org/c/coreboot/+/35443/1/src/mainboard/supermicro/x1... 
PS1, Line 4: n
> It means this: https://grml.org/faq/#whatmeans […]

Yeah, I know what this means; didn't see the :P ?

[Angel Pons (Code Review)]

Hello Michael Niewöhner, Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35443

to look at the new patch set (#3).

Change subject: mb/supermicro/x11ssh: simplify variant mechanism
......................................................................

mb/supermicro/x11ssh: simplify variant mechanism

The concept of a "baseboard" does not really make sense for retrofit
coreboot ports.

Change-Id: If64debe0dda6b32886f5288a6fe918b47c9dcd34
Signed-off-by: Angel Pons 
---
M src/mainboard/supermicro/x11ssh/Kconfig
M src/mainboard/supermicro/x11ssh/Kconfig.name
2 files changed, 4 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/35443/3

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35443 )

Change subject: mb/supermicro/x11ssh: simplify variant mechanism
......................................................................

Patch Set 3: Code-Review+1

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35443 )

Change subject: mb/supermicro/x11ssh: simplify variant mechanism
......................................................................

Patch Set 3: Code-Review-2

If you want to add variants it makes sense. I don't see any improvement, it even makes it worse. If you add 20 variants all of them have to be concatenated on the first line as done in #35427.
Selecting a base board is much cleaner design.

[Angel Pons (Code Review)]

Hello Patrick Rudolph, Michael Niewöhner, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35443

to look at the new patch set (#4).

Change subject: mb/supermicro/x11ssh: simplify variant mechanism
......................................................................

mb/supermicro/x11ssh: simplify variant mechanism

The concept of a "baseboard" does not really make sense for retrofit
coreboot ports.

Change-Id: If64debe0dda6b32886f5288a6fe918b47c9dcd34
Signed-off-by: Angel Pons 
---
M src/mainboard/supermicro/x11ssh/Kconfig
1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/35443/4

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35443 )

Change subject: mb/supermicro/x11ssh: simplify variant mechanism
......................................................................

Patch Set 4: Code-Review-1

(1 comment)

https://review.coreboot.org/c/coreboot/+/35443/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/35443/4//COMMIT_MSG@7 
PS4, Line 7: simplify variant mechanism
I don't think this is true anymore

[Angel Pons (Code Review)]

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/35443 )

Change subject: mb/supermicro/x11ssh: simplify variant mechanism
......................................................................

Abandoned

worthless