Change in coreboot[master]: sb/intel/ibexpeak: Don't link cougarpoint early usb setup

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Arthur Heymans (Code Review)

16 Sep 2019 16 Sep '19

11:05 a.m.

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35437 )

Change subject: sb/intel/ibexpeak: Don't link cougarpoint early usb setup ......................................................................

sb/intel/ibexpeak: Don't link cougarpoint early usb setup

While ibexpeak needs an equivalent of this code, it is not currently hooked up.

Change-Id: I980601e2302f2c412e823fef5fb9a69b9e151322 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/southbridge/intel/ibexpeak/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/35437/1

diff --git a/src/southbridge/intel/ibexpeak/Makefile.inc b/src/southbridge/intel/ibexpeak/Makefile.inc index fccb3a8..b5a0ac8 100644 --- a/src/southbridge/intel/ibexpeak/Makefile.inc +++ b/src/southbridge/intel/ibexpeak/Makefile.inc @@ -37,7 +37,7 @@

smm-y += smihandler.c me.c ../bd82x6x/me_8.x.c ../bd82x6x/pch.c

-romstage-y += ../bd82x6x/early_usb.c early_smbus.c ../bd82x6x/early_me.c ../bd82x6x/me_status.c ../common/gpio.c early_thermal.c +romstage-y += early_smbus.c ../bd82x6x/early_me.c ../bd82x6x/me_status.c ../common/gpio.c early_thermal.c romstage-y += ../bd82x6x/early_rcba.c

endif

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Patrick Rudolph (Code Review)

16 Sep 16 Sep

11:49 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35437 )

Change subject: sb/intel/ibexpeak: Don't link cougarpoint early usb setup ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/35437 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I980601e2302f2c412e823fef5fb9a69b9e151322 Gerrit-Change-Number: 35437 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 16 Sep 2019 11:49:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Kyösti Mälkki (Code Review)

12:10 p.m.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35437 )

Change subject: sb/intel/ibexpeak: Don't link cougarpoint early usb setup ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35437/1/src/southbridge/intel/ibexp... File src/southbridge/intel/ibexpeak/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/35437/1/src/southbridge/intel/ibexp... PS1, Line 40: romstage-y += early_smbus.c ../bd82x6x/early_me.c ../bd82x6x/me_status.c ../common/gpio.c early_thermal.c line length?

-- To view, visit https://review.coreboot.org/c/coreboot/+/35437 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I980601e2302f2c412e823fef5fb9a69b9e151322 Gerrit-Change-Number: 35437 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Mon, 16 Sep 2019 12:10:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Arthur Heymans (Code Review)

2:43 p.m.

New subject: Change in coreboot[master]: sb/intel/ibexpeak: Remove superfluous linked files

Hello Patrick Rudolph, Patrick Rudolph, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35437

to look at the new patch set (#2).

Change subject: sb/intel/ibexpeak: Remove superfluous linked files ......................................................................

sb/intel/ibexpeak: Remove superfluous linked files

../bd82x6x/early_usb.c: While ibexpeak needs an equivalent of this code, it is not currently hooked up.

../common/gpio.c: Already linked in common/Makefile.inc

Change-Id: I980601e2302f2c412e823fef5fb9a69b9e151322 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/southbridge/intel/ibexpeak/Makefile.inc 1 file changed, 4 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/35437/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35437 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I980601e2302f2c412e823fef5fb9a69b9e151322 Gerrit-Change-Number: 35437 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

9:11 p.m.

New subject: Change in coreboot[master]: sb/intel/ibexpeak: Remove superfluous linked files

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35437 )

Change subject: sb/intel/ibexpeak: Remove superfluous linked files ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35437 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I980601e2302f2c412e823fef5fb9a69b9e151322 Gerrit-Change-Number: 35437 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Mon, 16 Sep 2019 21:11:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Arthur Heymans (Code Review)

18 Sep 18 Sep

9:27 a.m.

New subject: Change in coreboot[master]: sb/intel/ibexpeak: Remove superfluous linked files

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35437 )

Change subject: sb/intel/ibexpeak: Remove superfluous linked files ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35437/1/src/southbridge/intel/ibexp... File src/southbridge/intel/ibexpeak/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/35437/1/src/southbridge/intel/ibexp... PS1, Line 40: romstage-y += early_smbus.c ../bd82x6x/early_me.c ../bd82x6x/me_status.c ../common/gpio.c early_thermal.c

...

line length?

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/35437 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I980601e2302f2c412e823fef5fb9a69b9e151322 Gerrit-Change-Number: 35437 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Wed, 18 Sep 2019 09:27:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-MessageType: comment

Arthur Heymans (Code Review)

9:28 a.m.

New subject: Change in coreboot[master]: sb/intel/ibexpeak: Remove superfluous linked files

Arthur Heymans has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35437 )

Change subject: sb/intel/ibexpeak: Remove superfluous linked files ......................................................................

sb/intel/ibexpeak: Remove superfluous linked files

../bd82x6x/early_usb.c: While ibexpeak needs an equivalent of this code, it is not currently hooked up.

../common/gpio.c: Already linked in common/Makefile.inc

Change-Id: I980601e2302f2c412e823fef5fb9a69b9e151322 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/35437 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/southbridge/intel/ibexpeak/Makefile.inc 1 file changed, 4 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved

diff --git a/src/southbridge/intel/ibexpeak/Makefile.inc b/src/southbridge/intel/ibexpeak/Makefile.inc index fccb3a8..83d083f 100644 --- a/src/southbridge/intel/ibexpeak/Makefile.inc +++ b/src/southbridge/intel/ibexpeak/Makefile.inc @@ -37,7 +37,10 @@

smm-y += smihandler.c me.c ../bd82x6x/me_8.x.c ../bd82x6x/pch.c

-romstage-y += ../bd82x6x/early_usb.c early_smbus.c ../bd82x6x/early_me.c ../bd82x6x/me_status.c ../common/gpio.c early_thermal.c +romstage-y += early_smbus.c +romstage-y +=../bd82x6x/early_me.c +romstage-y +=../bd82x6x/me_status.c +romstage-y += early_thermal.c romstage-y += ../bd82x6x/early_rcba.c

endif

-- To view, visit https://review.coreboot.org/c/coreboot/+/35437 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I980601e2302f2c412e823fef5fb9a69b9e151322 Gerrit-Change-Number: 35437 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-MessageType: merged

1703

days inactive

1705

days old

coreboot-gerrit@coreboot.org

6 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
Arthur Heymans (Code Review)
Kyösti Mälkki (Code Review)
Patrick Rudolph (Code Review)