Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31133 )
Change subject: soc/intel/cannonlake: Add SOC_INTEL_WHISKEYLAKE kconfig
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31133/4/src/soc/intel/cannonlake/Kconfig
File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/#/c/31133/4/src/soc/intel/cannonlake/Kconfig@26
PS4, Line 26: SOC_INTEL_CANNONLAKE
How about SOC_INTEL_CANNONLAKE || SOC_INTEL_COFFELAKE || SOC_INTEL_WHISKEYLAKE ?
Then we don't have to select SOC CANNONLAKE from coffeelake and whiskeylake configs.
This might help ease checks at many places, where we want to configure something SOC specific, even IS_CFL_OR_WHL config might not be needed then.
thoughts?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31133
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I66b63361841f5a16615ddce4225c4f6182eabdb3
Gerrit-Change-Number: 31133
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: PraveenX Hodagatta Pranesh
praveenx.hodagatta.pranesh@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 31 Jan 2019 05:57:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment