Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Nick Vaccaro.
Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60320 )
Change subject: mb/google/brya: Change SD Card and Touch pad GPIO PAD_RST to RSMRST
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60320/comment/ba04e6ed_a40dbcc0
PS3, Line 10: default state while the GPIO locking register gets a reset only in
during warm reset. […]
Done
https://review.coreboot.org/c/coreboot/+/60320/comment/87a9a913_01ef3c91
PS3, Line 11: RSMRST which prevents enumeration of SD card and Touch pad in
Can you put more detail as to why it prevents enumeration?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60320
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I558bab39f935ab31a89541c6498a73af70cbf9ee
Gerrit-Change-Number: 60320
Gerrit-PatchSet: 4
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Thu, 23 Dec 2021 11:08:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-MessageType: comment