Change in coreboot[master]: mb/google/dedede/var/lantis: Config I2C high and low time for touchsc...

[Tony Huang (Code Review)]

Tony Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49020 )

Change subject: mb/google/dedede/var/lantis: Config I2C high and low time for touchscreen/audio
......................................................................

mb/google/dedede/var/lantis: Config I2C high and low time for touchscreen/audio

BUG=b:173709409
BRANCH=dedede
TEST=EE measured result is 399/396.7kHZ

Change-Id: I970d69e6361d7cf6fcfc4e5b0b3c5fbfa885367c
Signed-off-by: Tony Huang 
---
M src/mainboard/google/dedede/variants/lantis/overridetree.cb
1 file changed, 12 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/49020/1

diff --git a/src/mainboard/google/dedede/variants/lantis/overridetree.cb b/src/mainboard/google/dedede/variants/lantis/overridetree.cb
index 1b87bcb..0d0528c 100644
--- a/src/mainboard/google/dedede/variants/lantis/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/lantis/overridetree.cb
@@ -36,9 +36,21 @@
    	},
    	.i2c[2] = {
    		.speed = I2C_SPEED_FAST,
+			.speed_config[0] = {
+				.speed = I2C_SPEED_FAST,
+				.scl_lcnt = 185,
+				.scl_hcnt = 95,
+				.sda_hold = 40,
+			}
    	},
    	.i2c[4] = {
    		.speed = I2C_SPEED_FAST,
+			.speed_config[0] = {
+				.speed = I2C_SPEED_FAST,
+				.scl_lcnt = 185,
+				.scl_hcnt = 95,
+				.sda_hold = 40,
+			}
    	},
    }"

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49020 )

Change subject: mb/google/dedede/var/lantis: Config I2C high and low time for touchscreen/audio
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/49020/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/49020/1//COMMIT_MSG@8 
PS1, Line 8: 
Please mention, where the values are documented.

[Tony Huang (Code Review)]

Hello build bot (Jenkins), Wisley Chen, Paul Fagerburg, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/49020

to look at the new patch set (#2).

Change subject: mb/google/dedede/var/lantis: Config I2C high and low time for touchscreen/audio
......................................................................

mb/google/dedede/var/lantis: Config I2C high and low time for touchscreen/audio

Config I2C high / low time in device tree to ensure I2C
CLK runs accurately at I2C_SPEED_FAST (400 kHz).

These tuning value is applied from touchpad as a base line,
and EE measured touchscreen/audio runs at 399/396.7kHz after tuning.

BUG=b:173709409
BRANCH=dedede
TEST=Build and check after tuning I2C clock is under 400kHz

Change-Id: I970d69e6361d7cf6fcfc4e5b0b3c5fbfa885367c
Signed-off-by: Tony Huang 
---
M src/mainboard/google/dedede/variants/lantis/overridetree.cb
1 file changed, 12 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/49020/2

[Tony Huang (Code Review)]

Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49020 )

Change subject: mb/google/dedede/var/lantis: Config I2C high and low time for touchscreen/audio
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/49020/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/49020/1//COMMIT_MSG@8 
PS1, Line 8:
> Please mention, where the values are documented.

Done

[Paul Fagerburg (Code Review)]

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49020 )

Change subject: mb/google/dedede/var/lantis: Config I2C high and low time for touchscreen/audio
......................................................................

Patch Set 2: Code-Review+1

[Tony Huang (Code Review)]

Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49020 )

Change subject: mb/google/dedede/var/lantis: Config I2C high and low time for touchscreen/audio
......................................................................

Patch Set 2:

Hi Karthik,
Please help review +2 if result is okay.
Thanks

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49020 )

Change subject: mb/google/dedede/var/lantis: Config I2C high and low time for touchscreen/audio
......................................................................

Patch Set 2: Code-Review+2

[Tony Huang (Code Review)]

Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49020 )

Change subject: mb/google/dedede/var/lantis: Config I2C high and low time for touchscreen/audio
......................................................................

Patch Set 2:

Hi Karthik,
Could you please help merge this CL, too?
Thanks

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49020 )

Change subject: mb/google/dedede/var/lantis: Config I2C high and low time for touchscreen/audio
......................................................................

mb/google/dedede/var/lantis: Config I2C high and low time for touchscreen/audio

Config I2C high / low time in device tree to ensure I2C
CLK runs accurately at I2C_SPEED_FAST (400 kHz).

These tuning value is applied from touchpad as a base line,
and EE measured touchscreen/audio runs at 399/396.7kHz after tuning.

BUG=b:173709409
BRANCH=dedede
TEST=Build and check after tuning I2C clock is under 400kHz

Change-Id: I970d69e6361d7cf6fcfc4e5b0b3c5fbfa885367c
Signed-off-by: Tony Huang 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/49020
Tested-by: build bot (Jenkins) 
Reviewed-by: Paul Fagerburg 
Reviewed-by: Karthik Ramasubramanian 
---
M src/mainboard/google/dedede/variants/lantis/overridetree.cb
1 file changed, 12 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Karthik Ramasubramanian: Looks good to me, approved
  Paul Fagerburg: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/dedede/variants/lantis/overridetree.cb b/src/mainboard/google/dedede/variants/lantis/overridetree.cb
index 1f53311..297a5c0 100644
--- a/src/mainboard/google/dedede/variants/lantis/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/lantis/overridetree.cb
@@ -42,9 +42,21 @@
    	},
    	.i2c[2] = {
    		.speed = I2C_SPEED_FAST,
+			.speed_config[0] = {
+				.speed = I2C_SPEED_FAST,
+				.scl_lcnt = 185,
+				.scl_hcnt = 95,
+				.sda_hold = 40,
+			}
    	},
    	.i2c[4] = {
    		.speed = I2C_SPEED_FAST,
+			.speed_config[0] = {
+				.speed = I2C_SPEED_FAST,
+				.scl_lcnt = 185,
+				.scl_hcnt = 95,
+				.sda_hold = 40,
+			}
    	},
    }"