Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82048?usp=email )
Change subject: soc/amd/common/amd_pci_util.h: rename bridge irq in pci_routing_info ......................................................................
soc/amd/common/amd_pci_util.h: rename bridge irq in pci_routing_info
Rename the 'irq' element of the pci_routing_info struct to 'bridge_irq' to better describe what it's doing. This struct element contains the number of the northbridge IOAPIC IRQ input the bridge IRQ is connected to signal power management or error reporting IRQs. Right now, coreboot doesn't put this information into the ACPI bytecode.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I6410be673d15d6f9b5eb4c80b51fb705fec5b155 Reviewed-on: https://review.coreboot.org/c/coreboot/+/82048 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@amd.corp-partner.google.com --- M src/soc/amd/common/block/include/amdblocks/amd_pci_util.h M src/soc/amd/common/fsp/pci/pci_routing_info.c 2 files changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/soc/amd/common/block/include/amdblocks/amd_pci_util.h b/src/soc/amd/common/block/include/amdblocks/amd_pci_util.h index f862bf9..db8b704 100644 --- a/src/soc/amd/common/block/include/amdblocks/amd_pci_util.h +++ b/src/soc/amd/common/block/include/amdblocks/amd_pci_util.h @@ -57,7 +57,7 @@ uint8_t devfn; uint8_t group; uint8_t swizzle; - uint8_t irq; + uint8_t bridge_irq; /* also called 'map' */ } __packed;
void populate_pirq_data(void); diff --git a/src/soc/amd/common/fsp/pci/pci_routing_info.c b/src/soc/amd/common/fsp/pci/pci_routing_info.c index 5e3c368..96ea1ff 100644 --- a/src/soc/amd/common/fsp/pci/pci_routing_info.c +++ b/src/soc/amd/common/fsp/pci/pci_routing_info.c @@ -34,9 +34,9 @@ routing_table_entries = routing_hob->num_of_entries;
for (size_t i = 0; i < routing_table_entries; ++i) { - printk(BIOS_DEBUG, "%02x.%x: group: %u, swizzle: %u, irq: %u\n", + printk(BIOS_DEBUG, "%02x.%x: group: %u, swizzle: %u, bridge irq: %u\n", PCI_SLOT(routing_table[i].devfn), PCI_FUNC(routing_table[i].devfn), - routing_table[i].group, routing_table[i].swizzle, routing_table[i].irq); + routing_table[i].group, routing_table[i].swizzle, routing_table[i].bridge_irq); }
*entries = routing_table_entries;