Attention is currently required from: Felix Held.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57349 )
Change subject: utils/abuild: select FSP_USE_REPO instead of ADD_FSP_BINARIES
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
So, if I understand this right, it only worked because for platforms
without public binaries the paths of the files to add were empty?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57349
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I72faa6f9e5f2b06ab7cd43595ae0b49bf4d39630
Gerrit-Change-Number: 57349
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 05 Sep 2021 09:49:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment