Attention is currently required from: Ravi kumar, Shelley Chen, Julius Werner, mturney mturney. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52662 )
Change subject: sc7180: Add display support for mipi panels ......................................................................
Patch Set 5:
(15 comments)
File src/mainboard/google/trogdor/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119040): https://review.coreboot.org/c/coreboot/+/52662/comment/0e735383_56b57959 PS5, Line 104: if(CONFIG(TROGDOR_HAS_MIPI_PANEL)) space required before the open parenthesis '('
File src/soc/qualcomm/sc7180/display/dsi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119040): https://review.coreboot.org/c/coreboot/+/52662/comment/8713dca5_02a79c9b PS5, Line 65: write32(&dsi0->trig_ctrl,DSI_DMA_STREAM1 << 8 | DSI_DMA_TRIGGER_SEL); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119040): https://review.coreboot.org/c/coreboot/+/52662/comment/68f89b26_18ee5463 PS5, Line 172: write32(&dsi0->int_ctrl,0x0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119040): https://review.coreboot.org/c/coreboot/+/52662/comment/c6c61423_a85fac87 PS5, Line 210: printk(BIOS_ERR, Invalid vsprintf pointer extension '%pk'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119040): https://review.coreboot.org/c/coreboot/+/52662/comment/b052e7b1_6d2491d4 PS5, Line 281: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119040): https://review.coreboot.org/c/coreboot/+/52662/comment/e42b453f_3ded9699 PS5, Line 289: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119040): https://review.coreboot.org/c/coreboot/+/52662/comment/1087cc46_3c013932 PS5, Line 292: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119040): https://review.coreboot.org/c/coreboot/+/52662/comment/708e2d82_44fae912 PS5, Line 299: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119040): https://review.coreboot.org/c/coreboot/+/52662/comment/bdc85903_3adaf95f PS5, Line 302: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119040): https://review.coreboot.org/c/coreboot/+/52662/comment/dd38c96b_ac86f2dd PS5, Line 319: write32(&dsi0->int_ctrl,0x0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119040): https://review.coreboot.org/c/coreboot/+/52662/comment/4e06882c_50d0312a PS5, Line 322: setbits32(&dsi0->int_ctrl,DSI_CMD_MODE_DMA_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119040): https://review.coreboot.org/c/coreboot/+/52662/comment/a45980ff_40725bfe PS5, Line 325: setbits32(&dsi0->int_ctrl,DSI_CMD_MODE_MDP_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119040): https://review.coreboot.org/c/coreboot/+/52662/comment/4227a6fa_e3c76cc7 PS5, Line 328: setbits32(&dsi0->int_ctrl,DSI_VIDEO_MODE_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119040): https://review.coreboot.org/c/coreboot/+/52662/comment/ab50d4f6_3321c18c PS5, Line 333: setbits32(&dsi0->int_ctrl,DSI_ERROR_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119040): https://review.coreboot.org/c/coreboot/+/52662/comment/87ee4467_55c27eb7 PS5, Line 343: if(!pinfo && !pinfo->init_cmd) space required before the open parenthesis '('
-
build bot (Jenkins) (Code Review)