Change in coreboot[master]: xeon_sp/skx: prepare acpi.* for merging

[Marc Jones (Code Review)]

Marc Jones has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45218 )

Change subject: xeon_sp/skx: prepare acpi.* for merging
......................................................................

xeon_sp/skx: prepare acpi.* for merging

Cleanup acpi.h in preparation for merging with cpx/ acpi.* files

Change-Id: I2a0dc964eeb7f8da53676eb94c4385ff8668f6af
Signed-off-by: Marc Jones 
---
M src/soc/intel/xeon_sp/skx/acpi.c
M src/soc/intel/xeon_sp/skx/include/soc/acpi.h
2 files changed, 4 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/45218/1

diff --git a/src/soc/intel/xeon_sp/skx/acpi.c b/src/soc/intel/xeon_sp/skx/acpi.c
index d984d9f..4797d90 100644
--- a/src/soc/intel/xeon_sp/skx/acpi.c
+++ b/src/soc/intel/xeon_sp/skx/acpi.c
@@ -82,7 +82,7 @@
    return current;
 }

-unsigned long acpi_madt_irq_overrides(unsigned long current)
+static unsigned long acpi_madt_irq_overrides(unsigned long current)
 {
    int sci = acpi_sci_irq();
    uint16_t flags = MP_IRQ_TRIGGER_LEVEL;
@@ -747,7 +747,7 @@
    return current;
 }

-void uncore_inject_dsdt(void)
+static void uncore_inject_dsdt(void)
 {
    size_t hob_size;
    const uint8_t uds_guid[16] = FSP_HOB_IIO_UNIVERSAL_DATA_GUID;
diff --git a/src/soc/intel/xeon_sp/skx/include/soc/acpi.h b/src/soc/intel/xeon_sp/skx/include/soc/acpi.h
index 0e00c2b..354ffb4 100644
--- a/src/soc/intel/xeon_sp/skx/include/soc/acpi.h
+++ b/src/soc/intel/xeon_sp/skx/include/soc/acpi.h
@@ -12,10 +12,9 @@
    uint8_t   buf[32];
 } MEM_BLK;

-void acpi_create_serialio_ssdt(acpi_header_t *ssdt);
-unsigned long acpi_madt_irq_overrides(unsigned long current);
 unsigned long northbridge_write_acpi_tables(const struct device *device,
    unsigned long current, struct acpi_rsdp *rsdp);
-void uncore_inject_dsdt(void);
+
+void motherboard_fill_fadt(acpi_fadt_t *fadt);

#endif /* _SOC_ACPI_H_ */

[Jay Talbott (Code Review)]

Jay Talbott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45218 )

Change subject: xeon_sp/skx: prepare acpi.* for merging
......................................................................

Patch Set 1: Code-Review+1

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45218 )

Change subject: xeon_sp/skx: prepare acpi.* for merging
......................................................................

Patch Set 2: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/45218/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45218/2//COMMIT_MSG@9 
PS2, Line 9: Cleanup
nit: Clean up

[Marc Jones (Code Review)]

Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Jonathan Zhang, Jay Talbott, Johnny Lin, Angel Pons, Morgan Jang, Bryant Ou, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45218

to look at the new patch set (#3).

Change subject: xeon_sp/skx: prepare acpi.* for merging
......................................................................

xeon_sp/skx: prepare acpi.* for merging

Clean up acpi.h in preparation for merging with cpx/ acpi.* files

Change-Id: I2a0dc964eeb7f8da53676eb94c4385ff8668f6af
Signed-off-by: Marc Jones 
---
M src/soc/intel/xeon_sp/skx/acpi.c
M src/soc/intel/xeon_sp/skx/include/soc/acpi.h
2 files changed, 4 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/45218/3

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45218 )

Change subject: xeon_sp/skx: prepare acpi.* for merging
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45218/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45218/2//COMMIT_MSG@9 
PS2, Line 9: Cleanup
> nit: Clean up

Done

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45218 )

Change subject: xeon_sp/skx: prepare acpi.* for merging
......................................................................

Patch Set 3: Code-Review+2

Change in coreboot[master]: soc/intel/xeon_sp/skx: Prepare acpi.* for merging

[Marc Jones (Code Review)]

Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Jonathan Zhang, Jay Talbott, Johnny Lin, Angel Pons, Morgan Jang, Bryant Ou, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45218

to look at the new patch set (#4).

Change subject: soc/intel/xeon_sp/skx: Prepare acpi.* for merging
......................................................................

soc/intel/xeon_sp/skx: Prepare acpi.* for merging

Clean up acpi.h in preparation for merging with cpx/ acpi.* files

Change-Id: I2a0dc964eeb7f8da53676eb94c4385ff8668f6af
Signed-off-by: Marc Jones 
---
M src/soc/intel/xeon_sp/skx/acpi.c
M src/soc/intel/xeon_sp/skx/include/soc/acpi.h
2 files changed, 4 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/45218/4

Change in coreboot[master]: soc/intel/xeon_sp/skx: Prepare acpi.* for merging

[Stefan Reinauer (Code Review)]

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45218 )

Change subject: soc/intel/xeon_sp/skx: Prepare acpi.* for merging
......................................................................

Patch Set 4: Code-Review+2

Change in coreboot[master]: soc/intel/xeon_sp/skx: Prepare acpi.* for merging

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45218 )

Change subject: soc/intel/xeon_sp/skx: Prepare acpi.* for merging
......................................................................

Patch Set 4:

Darn, patch rebase issue....

Change in coreboot[master]: soc/intel/xeon_sp/skx: Prepare acpi.* for merging

[Jay Talbott (Code Review)]

Jay Talbott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45218 )

Change subject: soc/intel/xeon_sp/skx: Prepare acpi.* for merging
......................................................................

Patch Set 5: Code-Review+1

Change in coreboot[master]: soc/intel/xeon_sp/skx: Prepare acpi.* for merging

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45218 )

Change subject: soc/intel/xeon_sp/skx: Prepare acpi.* for merging
......................................................................

Patch Set 6: Code-Review+2

Change in coreboot[master]: soc/intel/xeon_sp/skx: Prepare acpi.* for merging

[Marc Jones (Code Review)]

Marc Jones has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45218 )

Change subject: soc/intel/xeon_sp/skx: Prepare acpi.* for merging
......................................................................

soc/intel/xeon_sp/skx: Prepare acpi.* for merging

Clean up acpi.h in preparation for merging with cpx/ acpi.* files

Change-Id: I2a0dc964eeb7f8da53676eb94c4385ff8668f6af
Signed-off-by: Marc Jones 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45218
Reviewed-by: Angel Pons 
Reviewed-by: Jay Talbott 
Reviewed-by: Stefan Reinauer 
Tested-by: build bot (Jenkins) 
---
M src/soc/intel/xeon_sp/skx/acpi.c
M src/soc/intel/xeon_sp/skx/include/soc/acpi.h
2 files changed, 4 insertions(+), 5 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Stefan Reinauer: Looks good to me, approved
  Angel Pons: Looks good to me, approved
  Jay Talbott: Looks good to me, but someone else must approve

diff --git a/src/soc/intel/xeon_sp/skx/acpi.c b/src/soc/intel/xeon_sp/skx/acpi.c
index d984d9f..4797d90 100644
--- a/src/soc/intel/xeon_sp/skx/acpi.c
+++ b/src/soc/intel/xeon_sp/skx/acpi.c
@@ -82,7 +82,7 @@
    return current;
 }

-unsigned long acpi_madt_irq_overrides(unsigned long current)
+static unsigned long acpi_madt_irq_overrides(unsigned long current)
 {
    int sci = acpi_sci_irq();
    uint16_t flags = MP_IRQ_TRIGGER_LEVEL;
@@ -747,7 +747,7 @@
    return current;
 }

-void uncore_inject_dsdt(void)
+static void uncore_inject_dsdt(void)
 {
    size_t hob_size;
    const uint8_t uds_guid[16] = FSP_HOB_IIO_UNIVERSAL_DATA_GUID;
diff --git a/src/soc/intel/xeon_sp/skx/include/soc/acpi.h b/src/soc/intel/xeon_sp/skx/include/soc/acpi.h
index 5506bb7..4574d9c 100644
--- a/src/soc/intel/xeon_sp/skx/include/soc/acpi.h
+++ b/src/soc/intel/xeon_sp/skx/include/soc/acpi.h
@@ -11,10 +11,9 @@
    uint8_t   buf[32];
 } MEM_BLK;

-void acpi_create_serialio_ssdt(acpi_header_t *ssdt);
-unsigned long acpi_madt_irq_overrides(unsigned long current);
 unsigned long northbridge_write_acpi_tables(const struct device *device,
    unsigned long current, struct acpi_rsdp *rsdp);
-void uncore_inject_dsdt(void);
+
+void motherboard_fill_fadt(acpi_fadt_t *fadt);

#endif /* _SOC_ACPI_H_ */