John Su has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38811 )
Change subject: mb/google/drallion: Set baseline config for U42 and U62 CPU ......................................................................
mb/google/drallion: Set baseline config for U42 and U62 CPU
VR settings will be selected by CPU SKU.
Change-Id: Ie471dee0c70e1831a822860c0a44455772a2b8be Signed-off-by: John Su john_su@compal.corp-partner.google.com --- M src/mainboard/google/drallion/variants/drallion/devicetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/38811/1
diff --git a/src/mainboard/google/drallion/variants/drallion/devicetree.cb b/src/mainboard/google/drallion/variants/drallion/devicetree.cb index 06d3e5d..489b383 100644 --- a/src/mainboard/google/drallion/variants/drallion/devicetree.cb +++ b/src/mainboard/google/drallion/variants/drallion/devicetree.cb @@ -65,6 +65,9 @@ register "PchHdaIDispCodecDisconnect" = "1" register "PchHdaAudioLinkHda" = "1"
+ # Select CPU PL2/PL4 config + register "cpu_pl2_4_cfg" = "baseline" + # VR Settings Configuration for 2/4 Domains #+----------------+-------+-------+-------+-------+ #| Domain/Setting | SA | IA | GTUS | GTS |
John Su has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/38811 )
Change subject: mb/google/drallion: Set baseline config for U42 and U62 CPU ......................................................................
mb/google/drallion: Set baseline config for U42 and U62 CPU
VR settings will be selected by CPU SKU.
BUG=b:148912093 BRANCH=None TEST=build coreboot and checked IA_TDC from TAT tool.
Change-Id: Ie471dee0c70e1831a822860c0a44455772a2b8be Signed-off-by: John Su john_su@compal.corp-partner.google.com --- M src/mainboard/google/drallion/variants/drallion/devicetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/38811/2
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38811 )
Change subject: mb/google/drallion: Set baseline config for U42 and U62 CPU ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38811/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38811/2//COMMIT_MSG@7 PS2, Line 7: on: Set baseline config for U42 and U62 CPU you should say set cpu_pl2_4_cfg to baseline for Dralion. cpu_pl2_4_cfg is by board design not CPU
https://review.coreboot.org/c/coreboot/+/38811/2//COMMIT_MSG@9 PS2, Line 9: VR settings will be selected by CPU SKU. Proper VR settings will be selected by CPU SKU and cpu_pl2_4_cfg
Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38811 )
Change subject: mb/google/drallion: Set baseline config for U42 and U62 CPU ......................................................................
Patch Set 2: Code-Review+2
Hello EricR Lai, Kane Chen, Mathew King, Duncan Laurie, Marx Wang, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38811
to look at the new patch set (#3).
Change subject: mb/google/drallion: set cpu_pl2_4_cfg to baseline for Dralion ......................................................................
mb/google/drallion: set cpu_pl2_4_cfg to baseline for Dralion
Proper VR settings will be selected by CPU SKU and cpu_pl2_4_cfg.
BUG=b:148912093 BRANCH=None TEST=build coreboot and checked IA_TDC from TAT tool.
Change-Id: Ie471dee0c70e1831a822860c0a44455772a2b8be Signed-off-by: John Su john_su@compal.corp-partner.google.com --- M src/mainboard/google/drallion/variants/drallion/devicetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/38811/3
Hello EricR Lai, Kane Chen, Mathew King, Duncan Laurie, Marx Wang, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38811
to look at the new patch set (#4).
Change subject: mb/google/drallion: Set cpu_pl2_4_cfg to baseline for Dralion ......................................................................
mb/google/drallion: Set cpu_pl2_4_cfg to baseline for Dralion
Proper VR settings will be selected by CPU SKU and cpu_pl2_4_cfg.
BUG=b:148912093 BRANCH=None TEST=build coreboot and checked IA_TDC from TAT tool.
Change-Id: Ie471dee0c70e1831a822860c0a44455772a2b8be Signed-off-by: John Su john_su@compal.corp-partner.google.com --- M src/mainboard/google/drallion/variants/drallion/devicetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/38811/4
Hello EricR Lai, Kane Chen, Mathew King, Duncan Laurie, Marx Wang, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38811
to look at the new patch set (#5).
Change subject: mb/google/drallion: Set cpu_pl2_4_cfg to baseline for Drallion ......................................................................
mb/google/drallion: Set cpu_pl2_4_cfg to baseline for Drallion
Proper VR settings will be selected by CPU SKU and cpu_pl2_4_cfg.
BUG=b:148912093 BRANCH=None TEST=build coreboot and checked IA_TDC from TAT tool.
Change-Id: Ie471dee0c70e1831a822860c0a44455772a2b8be Signed-off-by: John Su john_su@compal.corp-partner.google.com --- M src/mainboard/google/drallion/variants/drallion/devicetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/38811/5
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38811 )
Change subject: mb/google/drallion: Set cpu_pl2_4_cfg to baseline for Drallion ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38811/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38811/2//COMMIT_MSG@7 PS2, Line 7: on: Set baseline config for U42 and U62 CPU
you should say set cpu_pl2_4_cfg to baseline for Dralion. […]
Done
https://review.coreboot.org/c/coreboot/+/38811/2//COMMIT_MSG@9 PS2, Line 9: VR settings will be selected by CPU SKU.
Proper VR settings will be selected by CPU SKU and cpu_pl2_4_cfg
Done
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38811 )
Change subject: mb/google/drallion: Set cpu_pl2_4_cfg to baseline for Drallion ......................................................................
Patch Set 5: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38811 )
Change subject: mb/google/drallion: Set cpu_pl2_4_cfg to baseline for Drallion ......................................................................
mb/google/drallion: Set cpu_pl2_4_cfg to baseline for Drallion
Proper VR settings will be selected by CPU SKU and cpu_pl2_4_cfg.
BUG=b:148912093 BRANCH=None TEST=build coreboot and checked IA_TDC from TAT tool.
Change-Id: Ie471dee0c70e1831a822860c0a44455772a2b8be Signed-off-by: John Su john_su@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38811 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Reviewed-by: Mathew King mathewk@chromium.org --- M src/mainboard/google/drallion/variants/drallion/devicetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified EricR Lai: Looks good to me, approved Mathew King: Looks good to me, approved
diff --git a/src/mainboard/google/drallion/variants/drallion/devicetree.cb b/src/mainboard/google/drallion/variants/drallion/devicetree.cb index 92f3fb9..cdb6288 100644 --- a/src/mainboard/google/drallion/variants/drallion/devicetree.cb +++ b/src/mainboard/google/drallion/variants/drallion/devicetree.cb @@ -65,6 +65,9 @@ register "PchHdaIDispCodecDisconnect" = "1" register "PchHdaAudioLinkHda" = "1"
+ # Select CPU PL2/PL4 config + register "cpu_pl2_4_cfg" = "baseline" + # VR Settings Configuration for 2/4 Domains #+----------------+-------+-------+-------+-------+ #| Domain/Setting | SA | IA | GTUS | GTS |
-
EricR Lai (Code Review) -
John Su (Code Review)
-
Kane Chen (Code Review)
-
Mathew King (Code Review)
-
Patrick Georgi (Code Review)