Change in coreboot[master]: vendorcode/eltan/Kconfig: Hide the Kconfig options when lacking support
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35954 )
Change subject: vendorcode/eltan/Kconfig: Hide the Kconfig options when lacking support ......................................................................
vendorcode/eltan/Kconfig: Hide the Kconfig options when lacking support
The vendorcode/eltan mboot and verified boot options only build if a few other Kconfig options are defined.
Change-Id: Ie333d2fbf294e23ec01df06ee551e2d09541c744 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/facebook/fbg1701/Kconfig M src/vendorcode/eltan/Kconfig 2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/35954/1
diff --git a/src/mainboard/facebook/fbg1701/Kconfig b/src/mainboard/facebook/fbg1701/Kconfig index 0aa4acc..a607705 100644 --- a/src/mainboard/facebook/fbg1701/Kconfig +++ b/src/mainboard/facebook/fbg1701/Kconfig @@ -30,6 +30,7 @@ select DISABLE_HPET select INTEL_GMA_HAVE_VBT select GENERIC_SPD_BIN + select USE_VENDORCODE_ELTAN
config ONBOARD_SAMSUNG_MEM bool "Onboard memory manufacturer Samsung" diff --git a/src/vendorcode/eltan/Kconfig b/src/vendorcode/eltan/Kconfig index 731dd2c..dc756ab 100644 --- a/src/vendorcode/eltan/Kconfig +++ b/src/vendorcode/eltan/Kconfig @@ -13,5 +13,10 @@ ## GNU General Public License for more details. ##
+config USE_VENDORCODE_ELTAN + bool + +if USE_VENDORCODE_ELTAN source src/vendorcode/eltan/security/mboot/Kconfig source src/vendorcode/eltan/security/verified_boot/Kconfig +endif
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35954 )
Change subject: vendorcode/eltan/Kconfig: Hide the Kconfig options when lacking support ......................................................................
Patch Set 1: Code-Review+1
Looks good to me. Makes the menu config cleaner.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35954 )
Change subject: vendorcode/eltan/Kconfig: Hide the Kconfig options when lacking support ......................................................................
Patch Set 1: Code-Review+1
Yeah, currently it shows up in chipset configuration for all boards...
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35954 )
Change subject: vendorcode/eltan/Kconfig: Hide the Kconfig options when lacking support ......................................................................
Patch Set 1: Code-Review+2
Arthur Heymans has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35954 )
Change subject: vendorcode/eltan/Kconfig: Hide the Kconfig options when lacking support ......................................................................
vendorcode/eltan/Kconfig: Hide the Kconfig options when lacking support
The vendorcode/eltan mboot and verified boot options only build if a few other Kconfig options are defined.
Change-Id: Ie333d2fbf294e23ec01df06ee551e2d09541c744 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/35954 Reviewed-by: Wim Vervoorn Reviewed-by: Michał Żygowski michal.zygowski@3mdeb.com Reviewed-by: Frans Hendriks fhendriks@eltan.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/facebook/fbg1701/Kconfig M src/vendorcode/eltan/Kconfig 2 files changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Wim Vervoorn: Looks good to me, but someone else must approve Frans Hendriks: Looks good to me, approved Michał Żygowski: Looks good to me, but someone else must approve
diff --git a/src/mainboard/facebook/fbg1701/Kconfig b/src/mainboard/facebook/fbg1701/Kconfig index 0aa4acc..a607705 100644 --- a/src/mainboard/facebook/fbg1701/Kconfig +++ b/src/mainboard/facebook/fbg1701/Kconfig @@ -30,6 +30,7 @@ select DISABLE_HPET select INTEL_GMA_HAVE_VBT select GENERIC_SPD_BIN + select USE_VENDORCODE_ELTAN
config ONBOARD_SAMSUNG_MEM bool "Onboard memory manufacturer Samsung" diff --git a/src/vendorcode/eltan/Kconfig b/src/vendorcode/eltan/Kconfig index 731dd2c..dc756ab 100644 --- a/src/vendorcode/eltan/Kconfig +++ b/src/vendorcode/eltan/Kconfig @@ -13,5 +13,10 @@ ## GNU General Public License for more details. ##
+config USE_VENDORCODE_ELTAN + bool + +if USE_VENDORCODE_ELTAN source src/vendorcode/eltan/security/mboot/Kconfig source src/vendorcode/eltan/security/verified_boot/Kconfig +endif
-
Arthur Heymans (Code Review) -
Frans Hendriks (Code Review)
-
Michał Żygowski (Code Review)
-
Wim Vervoorn (Code Review)