Change in ...coreboot[master]: console/init: Print log level in coreboot banner

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Paul Menzel (Code Review)

15 Jan 2019 15 Jan '19

3:27 p.m.

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30935

Change subject: console/init: Print log level in coreboot banner ......................................................................

console/init: Print log level in coreboot banner

Sometimes, it’s not clear, what log level is configured (in Kconfig and CMOS), so print the log level in the banner.

coreboot-4.9-354-gff6e99cebe Tue Jan 15 15:23:20 UTC 2019 bootblock starting (log level: 7)...

Change-Id: I82c87ae90cd53fd47458fc6df3ef2c7f238f0f3d Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/console/init.c 1 file changed, 3 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/30935/1

diff --git a/src/console/init.c b/src/console/init.c index 0bafdbe..0a2c275 100644 --- a/src/console/init.c +++ b/src/console/init.c @@ -84,6 +84,7 @@

car_set_var(console_inited, 1);

- printk(BIOS_NOTICE, "\n\ncoreboot-%s%s %s " ENV_STRING " starting...\n", - coreboot_version, coreboot_extra_version, coreboot_build); + printk(BIOS_NOTICE, "\n\ncoreboot-%s%s %s " ENV_STRING " starting (log level: %i)...\n", + coreboot_version, coreboot_extra_version, coreboot_build, + get_log_level()); }

Attachments:

attachment.htm (text/html — 2.8 KB)

Show replies by date

build bot (Jenkins) (Code Review)

15 Jan 15 Jan

3:27 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30935 )

Change subject: console/init: Print log level in coreboot banner ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/30935/1/src/console/init.c File src/console/init.c:

https://review.coreboot.org/#/c/30935/1/src/console/init.c@87 PS1, Line 87: printk(BIOS_NOTICE, "\n\ncoreboot-%s%s %s " ENV_STRING " starting (log level: %i)...\n", line over 80 characters

HAOUAS Elyes (Code Review)

5:53 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30935 )

Change subject: console/init: Print log level in coreboot banner ......................................................................

Patch Set 1: Code-Review+1

Arthur Heymans (Code Review)

6:25 p.m.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30935 )

Change subject: console/init: Print log level in coreboot banner ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/#/c/30935/1/src/console/init.c File src/console/init.c:

https://review.coreboot.org/#/c/30935/1/src/console/init.c@87 PS1, Line 87: BIOS_NOTICE Do we want to print the loglevel only if set to BIOS_NOTICE or higher? (real question, not saying this is bad)

Paul Menzel (Code Review)

16 Jan 16 Jan

12:01 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30935 )

Change subject: console/init: Print log level in coreboot banner ......................................................................

Patch Set 1:

(1 comment)

I guess the log level number should be enough, right? Or print the name on a separate line?

https://review.coreboot.org/#/c/30935/1/src/console/init.c File src/console/init.c:

https://review.coreboot.org/#/c/30935/1/src/console/init.c@87 PS1, Line 87: BIOS_NOTICE

...

Do we want to print the loglevel only if set to BIOS_NOTICE or higher? (real question, not saying th […]

According to the definitions of the log level, that is what should be done right now.

There was a discussion in the past, if an exception should be made for the banner, and to always print the banner. But, I forgot the outcome.

-- To view, visit https://review.coreboot.org/c/coreboot/+/30935 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82c87ae90cd53fd47458fc6df3ef2c7f238f0f3d Gerrit-Change-Number: 30935 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 16 Jan 2019 12:01:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz Gerrit-MessageType: comment

Patrick Georgi (Code Review)

12:52 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30935 )

Change subject: console/init: Print log level in coreboot banner ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/30935 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82c87ae90cd53fd47458fc6df3ef2c7f238f0f3d Gerrit-Change-Number: 30935 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Wed, 16 Jan 2019 12:52:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

12:53 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30935 )

Change subject: console/init: Print log level in coreboot banner ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/30935/1/src/console/init.c File src/console/init.c:

https://review.coreboot.org/#/c/30935/1/src/console/init.c@87 PS1, Line 87: BIOS_NOTICE

...

According to the definitions of the log level, that is what should be done right now. […]

I think it's fine to keep it at that level. Once you're not into notices, you probably don't care about the stages either.

-- To view, visit https://review.coreboot.org/c/coreboot/+/30935 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82c87ae90cd53fd47458fc6df3ef2c7f238f0f3d Gerrit-Change-Number: 30935 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Wed, 16 Jan 2019 12:53:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Patrick Georgi (Code Review)

17 Jan 17 Jan

1:19 p.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30935 )

Change subject: console/init: Print log level in coreboot banner ......................................................................

console/init: Print log level in coreboot banner

Sometimes, it’s not clear, what log level is configured (in Kconfig and CMOS), so print the log level in the banner.

coreboot-4.9-354-gff6e99cebe Tue Jan 15 15:23:20 UTC 2019 bootblock starting (log level: 7)...

Change-Id: I82c87ae90cd53fd47458fc6df3ef2c7f238f0f3d Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de Reviewed-on: https://review.coreboot.org/c/30935 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/console/init.c 1 file changed, 3 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved HAOUAS Elyes: Looks good to me, but someone else must approve Arthur Heymans: Looks good to me, but someone else must approve

diff --git a/src/console/init.c b/src/console/init.c index ff1d616..8aa7d7d 100644 --- a/src/console/init.c +++ b/src/console/init.c @@ -83,6 +83,7 @@

car_set_var(console_inited, 1);

-- To view, visit https://review.coreboot.org/c/coreboot/+/30935 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82c87ae90cd53fd47458fc6df3ef2c7f238f0f3d Gerrit-Change-Number: 30935 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-MessageType: merged

2142

days inactive

2144

days old

coreboot-gerrit@coreboot.org

7 comments

5 participants

tags (0)

participants (5)

Arthur Heymans (Code Review)
build bot (Jenkins) (Code Review)
HAOUAS Elyes (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)