Attention is currently required from: Robert Zieba, Raul Rangel, Nico Huber, Tim Wawrzynczak, Paul Menzel, Arthur Heymans, Kyösti Mälkki, Karthik Ramasubramanian.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63657 )
Change subject: arch/x86: Add support for catching null dereferences through debug regs
......................................................................
Patch Set 7:
(1 comment)
File src/arch/x86/breakpoint.c:
https://review.coreboot.org/c/coreboot/+/63657/comment/c6795a2c_db72055c
PS7, Line 41: = {0, 0, 0, 0}
No need, this happens automatically.
If you still want to keep the initializer, you can simply use `{ 0 }` regardless of how many elements the array has.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63657
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I113590689046a13c2a552741bbfe7668a834354a
Gerrit-Change-Number: 63657
Gerrit-PatchSet: 7
Gerrit-Owner: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Robert Zieba
robertzieba@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 02 May 2022 17:05:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment