Subrata Banik has posted comments on this change. ( https://review.coreboot.org/22607 )
Change subject: soc/intel/common: Add Intel SRAM common code support ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/#/c/22607/1/src/soc/intel/common/block/sram/sram... File src/soc/intel/common/block/sram/sram.c:
https://review.coreboot.org/#/c/22607/1/src/soc/intel/common/block/sram/sram... PS1, Line 58: read_resources sram_read_resources
https://review.coreboot.org/#/c/22607/1/src/soc/intel/common/block/sram/sram... PS1, Line 59: set_resources this can be replaced with pci_dev_set_resources as this one looks generic
https://review.coreboot.org/#/c/22607/1/src/soc/intel/common/block/sram/sram... PS1, Line 60: .enable_resources = pci_dev_enable_resources, why no .init function here? its always better to have weak link for .init
https://review.coreboot.org/#/c/22607/1/src/soc/intel/common/block/sram/sram... PS1, Line 69: pmc sram
-
Subrata Banik (Code Review)