Change in coreboot[master]: util/inteltool: Add GPIO dumping capabilites for Icelake U systems - coreboot-gerrit

6 Jan 2020


      Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38175 )
Change subject: util/inteltool: Add GPIO dumping capabilites for Icelake U systems
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
Please fix the hardcoded pad size in a better way, see comment
https://review.coreboot.org/c/coreboot/+/38175/6/util/inteltool/gpio_groups.... 
File util/inteltool/gpio_groups.c:
https://review.coreboot.org/c/coreboot/+/38175/6/util/inteltool/gpio_groups.... 
PS6, Line 2455: 	.pad_count	= 82 - 59 + 1,
Take a look at the previous impl.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/38175
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib40f1dbae57169678e92ea9ad0df60ff91b5b22c
Gerrit-Change-Number: 38175
Gerrit-PatchSet: 6
Gerrit-Owner: Mimoja coreboot@mimoja.de
Gerrit-Reviewer: Mimoja coreboot@mimoja.de
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Jeremy Soller jeremy@system76.com
Gerrit-CC: Matt DeVillier matt.devillier@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 06 Jan 2020 14:01:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment