Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/54361 )
Change subject: LGA1155 boards: Drop `VGA_BIOS_{FILE,ID}` for iGPU ......................................................................
LGA1155 boards: Drop `VGA_BIOS_{FILE,ID}` for iGPU
These boards have a socketed CPU, and the PCI device ID for the iGPU depends on the installed CPU. Specifying a default doesn't make sense.
Change-Id: Iee6749e4fb691f09664cc6ffb3cbf66e4230fa9c Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/54361 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/asus/maximus_iv_gene-z/Kconfig M src/mainboard/asus/p8h61-m_pro/Kconfig M src/mainboard/dell/optiplex_9010/Kconfig M src/mainboard/hp/compaq_8200_elite_sff/Kconfig M src/mainboard/hp/z220_sff_workstation/Kconfig M src/mainboard/sapphire/pureplatinumh61/Kconfig 6 files changed, 0 insertions(+), 44 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/mainboard/asus/maximus_iv_gene-z/Kconfig b/src/mainboard/asus/maximus_iv_gene-z/Kconfig index 81d5b97..6234365 100644 --- a/src/mainboard/asus/maximus_iv_gene-z/Kconfig +++ b/src/mainboard/asus/maximus_iv_gene-z/Kconfig @@ -28,10 +28,6 @@ string default "Maximus IV GENE-Z"
-config VGA_BIOS_ID - string - default "8086,0112" - config USBDEBUG_HCD_INDEX int default 1 diff --git a/src/mainboard/asus/p8h61-m_pro/Kconfig b/src/mainboard/asus/p8h61-m_pro/Kconfig index a619c17..d7b0c29 100644 --- a/src/mainboard/asus/p8h61-m_pro/Kconfig +++ b/src/mainboard/asus/p8h61-m_pro/Kconfig @@ -29,12 +29,4 @@ string default "P8H61-M PRO"
-config VGA_BIOS_FILE - string - default "pci8086,0152.rom" - -config VGA_BIOS_ID - string - default "8086,0152" - endif # BOARD_ASUS_P8H61_M_PRO diff --git a/src/mainboard/dell/optiplex_9010/Kconfig b/src/mainboard/dell/optiplex_9010/Kconfig index 3f5893c..597d481 100644 --- a/src/mainboard/dell/optiplex_9010/Kconfig +++ b/src/mainboard/dell/optiplex_9010/Kconfig @@ -28,14 +28,6 @@ string default "OptiPlex 9010"
-config VGA_BIOS_FILE - string - default "pci8086,0162.rom" - -config VGA_BIOS_ID - string - default "8086,0162" - config DRAM_RESET_GATE_GPIO int default 60 diff --git a/src/mainboard/hp/compaq_8200_elite_sff/Kconfig b/src/mainboard/hp/compaq_8200_elite_sff/Kconfig index 1564bb6..038a32e 100644 --- a/src/mainboard/hp/compaq_8200_elite_sff/Kconfig +++ b/src/mainboard/hp/compaq_8200_elite_sff/Kconfig @@ -30,14 +30,6 @@ string default "HP Compaq 8200 Elite SFF PC"
-config VGA_BIOS_FILE - string - default "pci8086,0102.rom" - -config VGA_BIOS_ID - string - default "8086,0102" - config DRAM_RESET_GATE_GPIO int default 60 diff --git a/src/mainboard/hp/z220_sff_workstation/Kconfig b/src/mainboard/hp/z220_sff_workstation/Kconfig index 12643bd..935547f 100644 --- a/src/mainboard/hp/z220_sff_workstation/Kconfig +++ b/src/mainboard/hp/z220_sff_workstation/Kconfig @@ -43,14 +43,6 @@ string default "HP Z220 SFF Workstation"
-config VGA_BIOS_FILE - string - default "pci8086,0102.rom" - -config VGA_BIOS_ID - string - default "8086,0102" - config DRAM_RESET_GATE_GPIO int default 60 diff --git a/src/mainboard/sapphire/pureplatinumh61/Kconfig b/src/mainboard/sapphire/pureplatinumh61/Kconfig index 9060181..7722f97 100644 --- a/src/mainboard/sapphire/pureplatinumh61/Kconfig +++ b/src/mainboard/sapphire/pureplatinumh61/Kconfig @@ -23,14 +23,6 @@ string default "Pure Platinum H61"
-config VGA_BIOS_FILE - string - default "pci8086,0162.rom" - -config VGA_BIOS_ID - string - default "8086,0162" - config DRAM_RESET_GATE_GPIO int default 60
-
Patrick Georgi (Code Review)