Attention is currently required from: Nico Huber, Paul Menzel, Arthur Heymans.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63982 )
Change subject: soc/intel/cmn/spi: Add ACPI SSDT extension for fast SPI
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63982/comment/ab1cda0d_c3b5eeea
PS1, Line 7: soc/intel/cmn/spi: Add ACPI SSDT extension for fast SPI
Mention APL somewhere in here?
Not sure if mentioning APL in the headline is helpful. Without the description the scope could be get wrong. Do you mind to not add APL here?
https://review.coreboot.org/c/coreboot/+/63982/comment/e01ca61a_fe740a38
PS1, Line 16: controller inaccessible from the OS.
Mention that flashrom is one of the affected use cases?
Sure, can do.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63982
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa89cdf41f42d4df5b46f095e22924157d9f3c3f
Gerrit-Change-Number: 63982
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 03 May 2022 08:20:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment