Attention is currently required from: Harsha B R, Sridhar Siricilla, Usha P.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72789 )
Change subject: mb/intel/mtlrvp: Enable ACPI support for Type-C ports
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/mainboard/intel/mtlrvp/variants/mtlrvp_p_ext_ec/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/72789/comment/6ff3c756_62562ed2
PS2, Line 7: use conn1 as mux_conn[1]
how about conn2/3?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72789
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e5957ca7a6c542a64d79b2ceefbed79ead15811
Gerrit-Change-Number: 72789
Gerrit-PatchSet: 2
Gerrit-Owner: Harsha B R
harsha.b.r@intel.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-CC: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Harsha B R
harsha.b.r@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Usha P
usha.p@intel.com
Gerrit-Comment-Date: Sun, 05 Feb 2023 07:09:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment