Attention is currently required from: Angel Pons.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52787 )
Change subject: nb/intel: Don't select VBOOT_SEPARATE_VERSTAGE
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
Should this change be advertised in the release notes?
Functionally not much changes.
File src/mainboard/emulation/qemu-i440fx/Kconfig:
https://review.coreboot.org/c/coreboot/+/52787/comment/4f5ef3f4_324b5b71
PS1, Line 22: VBOOT_SEPARATE_VERSTAGE
maybe this one is not too smart as the bootblock size is limited to 64K by the SOUTHBRIDGE_INTEL_I82371EB. I'll check on the sizes
With a lot of options selected it remains far off from 64K.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52787
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic92ecf8068f327a893d20924685ce571752d379f
Gerrit-Change-Number: 52787
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 03 May 2021 10:02:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment