HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33810
Change subject: [test] Add -Wsign-compare warning option ......................................................................
[test] Add -Wsign-compare warning option
Change-Id: I12961fc29ef90f73a5e09a4efdf586ee980cb6d6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/33810/1
diff --git a/Makefile.inc b/Makefile.inc index 362243e..37610a2 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -401,7 +401,7 @@
CFLAGS_common += -pipe -g -nostdinc -std=gnu11 CFLAGS_common += -nostdlib -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes -CFLAGS_common += -Wwrite-strings -Wredundant-decls -Wno-trigraphs +CFLAGS_common += -Wwrite-strings -Wredundant-decls -Wno-trigraphs -Wsign-compare CFLAGS_common += -Wstrict-aliasing -Wshadow -Wdate-time -Wtype-limits CFLAGS_common += -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer CFLAGS_common += -ffunction-sections -fdata-sections -fno-pie
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33810
to look at the new patch set (#3).
Change subject: [test] Add -Wsign-compare warning option ......................................................................
[test] Add -Wsign-compare warning option
Change-Id: I12961fc29ef90f73a5e09a4efdf586ee980cb6d6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/33810/3
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33810
to look at the new patch set (#4).
Change subject: [test] warning options ......................................................................
[test] warning options
Change-Id: I12961fc29ef90f73a5e09a4efdf586ee980cb6d6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/33810/4
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33810
to look at the new patch set (#5).
Change subject: [test] warning options ......................................................................
[test] warning options
Change-Id: I12961fc29ef90f73a5e09a4efdf586ee980cb6d6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/33810/5
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33810
to look at the new patch set (#6).
Change subject: [test] warning options ......................................................................
[test] warning options
Change-Id: I12961fc29ef90f73a5e09a4efdf586ee980cb6d6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/33810/6
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33810
to look at the new patch set (#9).
Change subject: [test] Wduplicated-branches and Wduplicated-cond warning options ......................................................................
[test] Wduplicated-branches and Wduplicated-cond warning options
Change-Id: I12961fc29ef90f73a5e09a4efdf586ee980cb6d6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/33810/9
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33810
to look at the new patch set (#10).
Change subject: [test] Wduplicated-branches and Wduplicated-cond warning options ......................................................................
[test] Wduplicated-branches and Wduplicated-cond warning options
Change-Id: I12961fc29ef90f73a5e09a4efdf586ee980cb6d6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc M src/device/dram/ddr2.c M src/device/dram/ddr3.c 3 files changed, 6 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/33810/10
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33810 )
Change subject: [test] Wduplicated-branches and Wduplicated-cond warning options ......................................................................
Patch Set 10:
(12 comments)
https://review.coreboot.org/c/coreboot/+/33810/10/src/device/dram/ddr2.c File src/device/dram/ddr2.c:
https://review.coreboot.org/c/coreboot/+/33810/10/src/device/dram/ddr2.c@528 PS10, Line 528: printram(" Capacity : %u",((dimm->size_mb < 1024)? dimm->size_mb: dimm->size_mb >> 10)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/33810/10/src/device/dram/ddr2.c@528 PS10, Line 528: printram(" Capacity : %u",((dimm->size_mb < 1024)? dimm->size_mb: dimm->size_mb >> 10)); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/33810/10/src/device/dram/ddr2.c@528 PS10, Line 528: printram(" Capacity : %u",((dimm->size_mb < 1024)? dimm->size_mb: dimm->size_mb >> 10)); spaces required around that '?' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/33810/10/src/device/dram/ddr2.c@528 PS10, Line 528: printram(" Capacity : %u",((dimm->size_mb < 1024)? dimm->size_mb: dimm->size_mb >> 10)); spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/33810/10/src/device/dram/ddr2.c@529 PS10, Line 529: printram((dimm->size_mb < 1024)? " MB\n": " GB\n"); spaces required around that '?' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/33810/10/src/device/dram/ddr2.c@529 PS10, Line 529: printram((dimm->size_mb < 1024)? " MB\n": " GB\n"); spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/33810/10/src/device/dram/ddr3.c File src/device/dram/ddr3.c:
https://review.coreboot.org/c/coreboot/+/33810/10/src/device/dram/ddr3.c@184 PS10, Line 184: printram(" Capacity : %u ",((capacity_shift < 0x02)? 256 << capacity_shift: 1 << (capacity_shift - 2))); line over 96 characters
https://review.coreboot.org/c/coreboot/+/33810/10/src/device/dram/ddr3.c@184 PS10, Line 184: printram(" Capacity : %u ",((capacity_shift < 0x02)? 256 << capacity_shift: 1 << (capacity_shift - 2))); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/33810/10/src/device/dram/ddr3.c@184 PS10, Line 184: printram(" Capacity : %u ",((capacity_shift < 0x02)? 256 << capacity_shift: 1 << (capacity_shift - 2))); spaces required around that '?' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/33810/10/src/device/dram/ddr3.c@184 PS10, Line 184: printram(" Capacity : %u ",((capacity_shift < 0x02)? 256 << capacity_shift: 1 << (capacity_shift - 2))); spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/33810/10/src/device/dram/ddr3.c@185 PS10, Line 185: printram((capacity_shift < 0x02)? " Mb\n": " Gb\n"); spaces required around that '?' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/33810/10/src/device/dram/ddr3.c@185 PS10, Line 185: printram((capacity_shift < 0x02)? " Mb\n": " Gb\n"); spaces required around that ':' (ctx:VxW)
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33810
to look at the new patch set (#11).
Change subject: [test] Wduplicated-branches and Wduplicated-cond warning options ......................................................................
[test] Wduplicated-branches and Wduplicated-cond warning options
Change-Id: I12961fc29ef90f73a5e09a4efdf586ee980cb6d6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc M src/device/dram/ddr2.c M src/device/dram/ddr3.c M src/northbridge/intel/nehalem/gma.c M src/northbridge/intel/sandybridge/gma.c 5 files changed, 14 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/33810/11
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33810 )
Change subject: [test] Wduplicated-branches and Wduplicated-cond warning options ......................................................................
Patch Set 11:
(12 comments)
https://review.coreboot.org/c/coreboot/+/33810/11/src/device/dram/ddr2.c File src/device/dram/ddr2.c:
https://review.coreboot.org/c/coreboot/+/33810/11/src/device/dram/ddr2.c@528 PS11, Line 528: printram(" Capacity : %u",((dimm->size_mb < 1024)? dimm->size_mb: dimm->size_mb >> 10)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/33810/11/src/device/dram/ddr2.c@528 PS11, Line 528: printram(" Capacity : %u",((dimm->size_mb < 1024)? dimm->size_mb: dimm->size_mb >> 10)); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/33810/11/src/device/dram/ddr2.c@528 PS11, Line 528: printram(" Capacity : %u",((dimm->size_mb < 1024)? dimm->size_mb: dimm->size_mb >> 10)); spaces required around that '?' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/33810/11/src/device/dram/ddr2.c@528 PS11, Line 528: printram(" Capacity : %u",((dimm->size_mb < 1024)? dimm->size_mb: dimm->size_mb >> 10)); spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/33810/11/src/device/dram/ddr2.c@529 PS11, Line 529: printram((dimm->size_mb < 1024)? " MB\n": " GB\n"); spaces required around that '?' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/33810/11/src/device/dram/ddr2.c@529 PS11, Line 529: printram((dimm->size_mb < 1024)? " MB\n": " GB\n"); spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/33810/11/src/device/dram/ddr3.c File src/device/dram/ddr3.c:
https://review.coreboot.org/c/coreboot/+/33810/11/src/device/dram/ddr3.c@184 PS11, Line 184: printram(" Capacity : %u ",((capacity_shift < 0x02)? 256 << capacity_shift: 1 << (capacity_shift - 2))); line over 96 characters
https://review.coreboot.org/c/coreboot/+/33810/11/src/device/dram/ddr3.c@184 PS11, Line 184: printram(" Capacity : %u ",((capacity_shift < 0x02)? 256 << capacity_shift: 1 << (capacity_shift - 2))); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/33810/11/src/device/dram/ddr3.c@184 PS11, Line 184: printram(" Capacity : %u ",((capacity_shift < 0x02)? 256 << capacity_shift: 1 << (capacity_shift - 2))); spaces required around that '?' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/33810/11/src/device/dram/ddr3.c@184 PS11, Line 184: printram(" Capacity : %u ",((capacity_shift < 0x02)? 256 << capacity_shift: 1 << (capacity_shift - 2))); spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/33810/11/src/device/dram/ddr3.c@185 PS11, Line 185: printram((capacity_shift < 0x02)? " Mb\n": " Gb\n"); spaces required around that '?' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/33810/11/src/device/dram/ddr3.c@185 PS11, Line 185: printram((capacity_shift < 0x02)? " Mb\n": " Gb\n"); spaces required around that ':' (ctx:VxW)
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33810 )
Change subject: [test] Wduplicated-branches and Wduplicated-cond warning options ......................................................................
Patch Set 12:
(12 comments)
https://review.coreboot.org/c/coreboot/+/33810/12/src/device/dram/ddr2.c File src/device/dram/ddr2.c:
https://review.coreboot.org/c/coreboot/+/33810/12/src/device/dram/ddr2.c@528 PS12, Line 528: printram(" Capacity : %u",((dimm->size_mb < 1024)? dimm->size_mb: dimm->size_mb >> 10)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/33810/12/src/device/dram/ddr2.c@528 PS12, Line 528: printram(" Capacity : %u",((dimm->size_mb < 1024)? dimm->size_mb: dimm->size_mb >> 10)); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/33810/12/src/device/dram/ddr2.c@528 PS12, Line 528: printram(" Capacity : %u",((dimm->size_mb < 1024)? dimm->size_mb: dimm->size_mb >> 10)); spaces required around that '?' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/33810/12/src/device/dram/ddr2.c@528 PS12, Line 528: printram(" Capacity : %u",((dimm->size_mb < 1024)? dimm->size_mb: dimm->size_mb >> 10)); spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/33810/12/src/device/dram/ddr2.c@529 PS12, Line 529: printram((dimm->size_mb < 1024)? " MB\n": " GB\n"); spaces required around that '?' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/33810/12/src/device/dram/ddr2.c@529 PS12, Line 529: printram((dimm->size_mb < 1024)? " MB\n": " GB\n"); spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/33810/12/src/device/dram/ddr3.c File src/device/dram/ddr3.c:
https://review.coreboot.org/c/coreboot/+/33810/12/src/device/dram/ddr3.c@184 PS12, Line 184: printram(" Capacity : %u ",((capacity_shift < 0x02)? 256 << capacity_shift: 1 << (capacity_shift - 2))); line over 96 characters
https://review.coreboot.org/c/coreboot/+/33810/12/src/device/dram/ddr3.c@184 PS12, Line 184: printram(" Capacity : %u ",((capacity_shift < 0x02)? 256 << capacity_shift: 1 << (capacity_shift - 2))); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/33810/12/src/device/dram/ddr3.c@184 PS12, Line 184: printram(" Capacity : %u ",((capacity_shift < 0x02)? 256 << capacity_shift: 1 << (capacity_shift - 2))); spaces required around that '?' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/33810/12/src/device/dram/ddr3.c@184 PS12, Line 184: printram(" Capacity : %u ",((capacity_shift < 0x02)? 256 << capacity_shift: 1 << (capacity_shift - 2))); spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/33810/12/src/device/dram/ddr3.c@185 PS12, Line 185: printram((capacity_shift < 0x02)? " Mb\n": " Gb\n"); spaces required around that '?' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/33810/12/src/device/dram/ddr3.c@185 PS12, Line 185: printram((capacity_shift < 0x02)? " Mb\n": " Gb\n"); spaces required around that ':' (ctx:VxW)
Hello Patrick Rudolph, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33810
to look at the new patch set (#13).
Change subject: [test] ......................................................................
[test]
Change-Id: I12961fc29ef90f73a5e09a4efdf586ee980cb6d6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/33810/13
Hello Patrick Rudolph, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33810
to look at the new patch set (#14).
Change subject: [test] ......................................................................
[test]
Change-Id: I12961fc29ef90f73a5e09a4efdf586ee980cb6d6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc M src/device/dram/ddr2.c M src/device/dram/ddr3.c M src/northbridge/intel/sandybridge/gma.c 4 files changed, 11 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/33810/14
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33810 )
Change subject: [test] ......................................................................
Abandoned