Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger. Hello Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62517
to look at the new patch set (#2).
Change subject: soc/amd/picasso/acpi: generate PPKG object in generate_cpu_entries call ......................................................................
soc/amd/picasso/acpi: generate PPKG object in generate_cpu_entries call
Generate the PPKG object in the generate_cpu_entries function instead of generating the PCNT object that is the used in the PPKG method in cpu.asl to provide the PPKG object. This both simplifies the code and aligns Picasso with Cezanne and Sabrina. This will also make the code behave correctly in a case where the number of CPU cores/threads isn't a power of two.
TEST=Mandolin still boots successfully to Linux desktop and dmesg doesn't show any any possibly related problems.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Ifb84435345c6d8c5d11a8b42e5538cfb86432780 --- M src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl M src/soc/amd/picasso/acpi.c M src/soc/amd/picasso/acpi/cpu.asl 3 files changed, 3 insertions(+), 54 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/62517/2