Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41837 )
Change subject: mb/google/zork: Delete sb_fch.asl ......................................................................
mb/google/zork: Delete sb_fch.asl
This file is not used.
BUG=b:154756391 TEST=Build trembyle and check that peripherals still work
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I721e295546aa75c9745a4836425b6e3e0067afaf --- D src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sb_fch.asl 1 file changed, 0 insertions(+), 246 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/41837/1
diff --git a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sb_fch.asl b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sb_fch.asl deleted file mode 100644 index 21c31a3..0000000 --- a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sb_fch.asl +++ /dev/null @@ -1,246 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <soc/gpio.h> -#include <soc/iomap.h> - -Device (AAHB) -{ - Name (_HID, "AAHB0000") - Name (_UID, 0x0) - Name (_CRS, ResourceTemplate() - { - Memory32Fixed (ReadWrite, ALINK_AHB_ADDRESS, 0x2000) - }) - - Method (_STA, 0x0, NotSerialized) - { - Return (0x0F) - } -} - -Device (GPIO) -{ - Name (_HID, GPIO_DEVICE_NAME) - Name (_CID, GPIO_DEVICE_NAME) - Name (_UID, 0) - Name (_DDN, GPIO_DEVICE_DESC) - - Method(_CRS ,0) { - local0=ResourceTemplate(){ - Interrupt ( - ResourceConsumer, - Level, - ActiveLow, - Exclusive, , , IRQR) - { 0 } - Memory32Fixed (ReadWrite, 0xFED81500, 0x300) - } - CreateDWordField(local0, IRQR._INT, IRQN) - If(PMOD) { - IRQN=IGPI - } Else { - IRQN=PGPI - } - If (IRQN == 0x1f) { - Return(ResourceTemplate(){ - Memory32Fixed (ReadWrite, 0xFED81500, 0x300) - }) - } Else { - Return(local0) - } - } - - Method (_STA, 0x0, NotSerialized) - { - Return (0x0F) - } -} - -Device (MMC0) -{ - Name (_HID, "AMDI0040") - Name (_UID, 0x0) - Method(_CRS ,0) { - local0=ResourceTemplate(){ - Interrupt ( - ResourceConsumer, - Level, - ActiveLow, - Exclusive, , , IRQR) - { 0 } - Memory32Fixed (ReadWrite, APU_EMMC_BASE, 0x1000) - } - CreateDWordField(local0, IRQR._INT, IRQN) - If(PMOD) { - IRQN=IMMC - } Else { - IRQN=PMMC - } - If (IRQN == 0x1f) { - Return(ResourceTemplate(){ - Memory32Fixed (ReadWrite, APU_EMMC_BASE, 0x1000) - }) - } Else { - Return(local0) - } - } - - Method (_STA, 0x0, NotSerialized) - { - Return (0x0F) - } -} - -Device (FUR0) -{ - Name (_HID, "AMD0020") - Name (_UID, 0x0) - Method(_CRS ,0) { - local0=ResourceTemplate(){ - Interrupt ( - ResourceConsumer, - Edge, - ActiveHigh, - Exclusive, , , IRQR) - { 0 } - Memory32Fixed (ReadWrite, APU_UART0_BASE, 0x1000) - Memory32Fixed (ReadWrite, APU_DMAC0_BASE, 0x1000) - } - CreateDWordField(local0, IRQR._INT, IRQN) - If(PMOD) { - IRQN=IUA0 - } Else { - IRQN=PUA0 - } - If (IRQN == 0x1f) { - Return(ResourceTemplate(){ - Memory32Fixed (ReadWrite, APU_UART0_BASE, 0x1000) - Memory32Fixed (ReadWrite, APU_DMAC0_BASE, 0x1000) - }) - } Else { - Return(local0) - } - } - - Method (_STA, 0x0, NotSerialized) - { - Return (0x0F) - } -} - -Device (FUR1) { - Name (_HID, "AMD0020") - Name (_UID, 0x1) - Method(_CRS ,0) { - local0=ResourceTemplate(){ - Interrupt ( - ResourceConsumer, - Edge, - ActiveHigh, - Exclusive, , , IRQR) - { 0 } - Memory32Fixed (ReadWrite, APU_UART1_BASE, 0x1000) - Memory32Fixed (ReadWrite, APU_DMAC1_BASE, 0x1000) - } - CreateDWordField(local0, IRQR._INT, IRQN) - If(PMOD) { - IRQN=IUA1 - } Else { - IRQN=PUA1 - } - If (IRQN == 0x1f) { - Return(ResourceTemplate(){ - Memory32Fixed (ReadWrite, APU_UART1_BASE, 0x1000) - Memory32Fixed (ReadWrite, APU_DMAC1_BASE, 0x1000) - }) - } Else { - Return(local0) - } - } - - Method (_STA, 0x0, NotSerialized) - { - Return (0x0F) - } -} - -Device (I2C2) { - Name (_HID, "AMD0010") - Name (_UID, 0x2) - Method(_CRS ,0) { - local0=ResourceTemplate(){ - Interrupt ( - ResourceConsumer, - Edge, - ActiveHigh, - Exclusive, , , IRQR) - { 0 } - Memory32Fixed (ReadWrite, APU_I2C2_BASE, 0x1000) - } - CreateDWordField(local0, IRQR._INT, IRQN) - If(PMOD) { - IRQN=II22 - } Else { - IRQN=PI22 - } - If (IRQN == 0x1f) { - Return(ResourceTemplate(){ - Memory32Fixed (ReadWrite, APU_I2C2_BASE, 0x1000) - }) - } Else { - Return(local0) - } - } - - Method (_STA, 0x0, NotSerialized) - { - Return (0x0F) - } -} - -Device (I2C3) -{ - Name (_HID, "AMD0010") - Name (_UID, 0x3) - Method(_CRS ,0) { - local0=ResourceTemplate(){ - Interrupt ( - ResourceConsumer, - Edge, - ActiveHigh, - Exclusive, , , IRQR) - { 0 } - Memory32Fixed (ReadWrite, APU_I2C3_BASE, 0x1000) - } - CreateDWordField(local0, IRQR._INT, IRQN) - If(PMOD) { - IRQN=II23 - } Else { - IRQN=PI23 - } - If (IRQN == 0x1f) { - Return(ResourceTemplate(){ - Memory32Fixed (ReadWrite, APU_I2C3_BASE, 0x1000) - }) - } Else { - Return(local0) - } - } - Method (_STA, 0x0, NotSerialized) - { - Return (0x0F) - } -} - -Device (MISC) -{ - Name (_HID, "AMD0040") - Name (_UID, 0x3) - Name (_CRS, ResourceTemplate() { - Memory32Fixed(ReadWrite, ACPIMMIO_MISC_BASE, 0x100) - }) - Method (_STA, 0x0, NotSerialized) - { - Return (0x0F) - } -}
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41837 )
Change subject: mb/google/zork: Delete sb_fch.asl ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41837 )
Change subject: mb/google/zork: Delete sb_fch.asl ......................................................................
Patch Set 1: Code-Review+2
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41837 )
Change subject: mb/google/zork: Delete sb_fch.asl ......................................................................
Uploaded patch set 2: Patch Set 1 was rebased.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41837 )
Change subject: mb/google/zork: Delete sb_fch.asl ......................................................................
Uploaded patch set 3: Patch Set 2 was rebased.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41837 )
Change subject: mb/google/zork: Delete sb_fch.asl ......................................................................
Uploaded patch set 4: Patch Set 3 was rebased.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41837 )
Change subject: mb/google/zork: Delete sb_fch.asl ......................................................................
mb/google/zork: Delete sb_fch.asl
This file is not used.
BUG=b:154756391 TEST=Build trembyle and check that peripherals still work
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I721e295546aa75c9745a4836425b6e3e0067afaf Reviewed-on: https://review.coreboot.org/c/coreboot/+/41837 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com --- D src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sb_fch.asl 1 file changed, 0 insertions(+), 246 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sb_fch.asl b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sb_fch.asl deleted file mode 100644 index 21c31a3..0000000 --- a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sb_fch.asl +++ /dev/null @@ -1,246 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <soc/gpio.h> -#include <soc/iomap.h> - -Device (AAHB) -{ - Name (_HID, "AAHB0000") - Name (_UID, 0x0) - Name (_CRS, ResourceTemplate() - { - Memory32Fixed (ReadWrite, ALINK_AHB_ADDRESS, 0x2000) - }) - - Method (_STA, 0x0, NotSerialized) - { - Return (0x0F) - } -} - -Device (GPIO) -{ - Name (_HID, GPIO_DEVICE_NAME) - Name (_CID, GPIO_DEVICE_NAME) - Name (_UID, 0) - Name (_DDN, GPIO_DEVICE_DESC) - - Method(_CRS ,0) { - local0=ResourceTemplate(){ - Interrupt ( - ResourceConsumer, - Level, - ActiveLow, - Exclusive, , , IRQR) - { 0 } - Memory32Fixed (ReadWrite, 0xFED81500, 0x300) - } - CreateDWordField(local0, IRQR._INT, IRQN) - If(PMOD) { - IRQN=IGPI - } Else { - IRQN=PGPI - } - If (IRQN == 0x1f) { - Return(ResourceTemplate(){ - Memory32Fixed (ReadWrite, 0xFED81500, 0x300) - }) - } Else { - Return(local0) - } - } - - Method (_STA, 0x0, NotSerialized) - { - Return (0x0F) - } -} - -Device (MMC0) -{ - Name (_HID, "AMDI0040") - Name (_UID, 0x0) - Method(_CRS ,0) { - local0=ResourceTemplate(){ - Interrupt ( - ResourceConsumer, - Level, - ActiveLow, - Exclusive, , , IRQR) - { 0 } - Memory32Fixed (ReadWrite, APU_EMMC_BASE, 0x1000) - } - CreateDWordField(local0, IRQR._INT, IRQN) - If(PMOD) { - IRQN=IMMC - } Else { - IRQN=PMMC - } - If (IRQN == 0x1f) { - Return(ResourceTemplate(){ - Memory32Fixed (ReadWrite, APU_EMMC_BASE, 0x1000) - }) - } Else { - Return(local0) - } - } - - Method (_STA, 0x0, NotSerialized) - { - Return (0x0F) - } -} - -Device (FUR0) -{ - Name (_HID, "AMD0020") - Name (_UID, 0x0) - Method(_CRS ,0) { - local0=ResourceTemplate(){ - Interrupt ( - ResourceConsumer, - Edge, - ActiveHigh, - Exclusive, , , IRQR) - { 0 } - Memory32Fixed (ReadWrite, APU_UART0_BASE, 0x1000) - Memory32Fixed (ReadWrite, APU_DMAC0_BASE, 0x1000) - } - CreateDWordField(local0, IRQR._INT, IRQN) - If(PMOD) { - IRQN=IUA0 - } Else { - IRQN=PUA0 - } - If (IRQN == 0x1f) { - Return(ResourceTemplate(){ - Memory32Fixed (ReadWrite, APU_UART0_BASE, 0x1000) - Memory32Fixed (ReadWrite, APU_DMAC0_BASE, 0x1000) - }) - } Else { - Return(local0) - } - } - - Method (_STA, 0x0, NotSerialized) - { - Return (0x0F) - } -} - -Device (FUR1) { - Name (_HID, "AMD0020") - Name (_UID, 0x1) - Method(_CRS ,0) { - local0=ResourceTemplate(){ - Interrupt ( - ResourceConsumer, - Edge, - ActiveHigh, - Exclusive, , , IRQR) - { 0 } - Memory32Fixed (ReadWrite, APU_UART1_BASE, 0x1000) - Memory32Fixed (ReadWrite, APU_DMAC1_BASE, 0x1000) - } - CreateDWordField(local0, IRQR._INT, IRQN) - If(PMOD) { - IRQN=IUA1 - } Else { - IRQN=PUA1 - } - If (IRQN == 0x1f) { - Return(ResourceTemplate(){ - Memory32Fixed (ReadWrite, APU_UART1_BASE, 0x1000) - Memory32Fixed (ReadWrite, APU_DMAC1_BASE, 0x1000) - }) - } Else { - Return(local0) - } - } - - Method (_STA, 0x0, NotSerialized) - { - Return (0x0F) - } -} - -Device (I2C2) { - Name (_HID, "AMD0010") - Name (_UID, 0x2) - Method(_CRS ,0) { - local0=ResourceTemplate(){ - Interrupt ( - ResourceConsumer, - Edge, - ActiveHigh, - Exclusive, , , IRQR) - { 0 } - Memory32Fixed (ReadWrite, APU_I2C2_BASE, 0x1000) - } - CreateDWordField(local0, IRQR._INT, IRQN) - If(PMOD) { - IRQN=II22 - } Else { - IRQN=PI22 - } - If (IRQN == 0x1f) { - Return(ResourceTemplate(){ - Memory32Fixed (ReadWrite, APU_I2C2_BASE, 0x1000) - }) - } Else { - Return(local0) - } - } - - Method (_STA, 0x0, NotSerialized) - { - Return (0x0F) - } -} - -Device (I2C3) -{ - Name (_HID, "AMD0010") - Name (_UID, 0x3) - Method(_CRS ,0) { - local0=ResourceTemplate(){ - Interrupt ( - ResourceConsumer, - Edge, - ActiveHigh, - Exclusive, , , IRQR) - { 0 } - Memory32Fixed (ReadWrite, APU_I2C3_BASE, 0x1000) - } - CreateDWordField(local0, IRQR._INT, IRQN) - If(PMOD) { - IRQN=II23 - } Else { - IRQN=PI23 - } - If (IRQN == 0x1f) { - Return(ResourceTemplate(){ - Memory32Fixed (ReadWrite, APU_I2C3_BASE, 0x1000) - }) - } Else { - Return(local0) - } - } - Method (_STA, 0x0, NotSerialized) - { - Return (0x0F) - } -} - -Device (MISC) -{ - Name (_HID, "AMD0040") - Name (_UID, 0x3) - Name (_CRS, ResourceTemplate() { - Memory32Fixed(ReadWrite, ACPIMMIO_MISC_BASE, 0x100) - }) - Method (_STA, 0x0, NotSerialized) - { - Return (0x0F) - } -}
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41837 )
Change subject: mb/google/zork: Delete sb_fch.asl ......................................................................
Patch Set 5:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4755 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4754 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4753 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4752
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Aaron Durbin (Code Review)
-
Furquan Shaikh (Code Review)
-
Patrick Georgi (Code Review)
-
Raul Rangel (Code Review)