Attention is currently required from: Jason Glenesk, Raul Rangel. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50512 )
Change subject: soc/amd: add and use fch_enable_hpet_decode ......................................................................
Patch Set 2:
(2 comments)
File src/soc/amd/common/block/acpimmio/mmio_util.c:
https://review.coreboot.org/c/coreboot/+/50512/comment/621bb7a6_ee6740e4 PS2, Line 79: HPET_FED0_EN
I feel like we should enable hpet_msi_en and hpet_width_sel. […]
those are the default values after reset. might be a good idea to explicitly set/clear them to be sure that they're in the state we expect them to be in
File src/soc/amd/common/block/include/amdblocks/acpimmio.h:
https://review.coreboot.org/c/coreboot/+/50512/comment/6a622189_9b775dbd PS2, Line 20: FED0
FED0?
yes, there are two possible mappings for the hpet and the usual one that we'll be using and announcing in ACPI is at fed00000. or do you want me to add the remaining four zeros?
-
Felix Held (Code Review)