Attention is currently required from: David Wu, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Paul Menzel, Subrata Banik, Tarun.
Tyler Wang has posted comments on this change by Tyler Wang. ( https://review.coreboot.org/c/coreboot/+/85100?usp=email )
Change subject: mb/google/rex/var/kanix: Add audio codec/amp support
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85100/comment/4ccda70b_41869d42?usp... :
PS2, Line 9: Add support for audio codec ALC5682I-VS and audio amp
: ALC1019.
Fits in one line.
After add "Realtek", the commit message will be longer than 75 characters. It has to be 2 lines.
Please help to take a look, thanks.
https://review.coreboot.org/c/coreboot/+/85100/comment/b4b0fa10_08e6b4ba?usp... :
PS2, Line 11:
Also mention the Realtek devices?
Done, thanks for your advice.
https://review.coreboot.org/c/coreboot/+/85100/comment/b6134afa_d36e7ab6?usp... :
PS2, Line 11:
Also mention the Realtek devices?
Done, thanks for your advise.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85100?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0cac934004b0b1b72feaacea99a602fffd2f1457
Gerrit-Change-Number: 85100
Gerrit-PatchSet: 3
Gerrit-Owner: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Tue, 12 Nov 2024 02:49:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org