Attention is currently required from: Ravi kumar. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56399 )
Change subject: soc/qualcomm/common/spi: Configure SPI QUP driver ......................................................................
Patch Set 3:
(16 comments)
File src/soc/qualcomm/common/spi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124831): https://review.coreboot.org/c/coreboot/+/56399/comment/f0b601a4_8a46ec0f PS3, Line 17: .claim_bus = qup_spi_claim_bus, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124831): https://review.coreboot.org/c/coreboot/+/56399/comment/68cf3c05_8444f94b PS3, Line 17: .claim_bus = qup_spi_claim_bus, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124831): https://review.coreboot.org/c/coreboot/+/56399/comment/b21e6859_822afa6b PS3, Line 18: .release_bus = qup_spi_release_bus, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124831): https://review.coreboot.org/c/coreboot/+/56399/comment/bdf400ac_d7a17755 PS3, Line 18: .release_bus = qup_spi_release_bus, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124831): https://review.coreboot.org/c/coreboot/+/56399/comment/134b2580_d9cbe1df PS3, Line 19: .xfer = qup_spi_xfer, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124831): https://review.coreboot.org/c/coreboot/+/56399/comment/a2e1262a_fe5940cc PS3, Line 19: .xfer = qup_spi_xfer, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124831): https://review.coreboot.org/c/coreboot/+/56399/comment/3d402e01_b1c1662a PS3, Line 20: .max_xfer_size = 65535, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124831): https://review.coreboot.org/c/coreboot/+/56399/comment/63e16b14_ed177318 PS3, Line 20: .max_xfer_size = 65535, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124831): https://review.coreboot.org/c/coreboot/+/56399/comment/5f88000f_035effcc PS3, Line 30: .ctrlr = &spi_qup_ctrlr, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124831): https://review.coreboot.org/c/coreboot/+/56399/comment/6c786c3c_276d92d5 PS3, Line 30: .ctrlr = &spi_qup_ctrlr, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124831): https://review.coreboot.org/c/coreboot/+/56399/comment/98d8c049_604d1432 PS3, Line 31: .bus_start = 0, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124831): https://review.coreboot.org/c/coreboot/+/56399/comment/3afbe12e_40d105d8 PS3, Line 31: .bus_start = 0, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124831): https://review.coreboot.org/c/coreboot/+/56399/comment/372ea34c_71cb1345 PS3, Line 32: .bus_end = 11, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124831): https://review.coreboot.org/c/coreboot/+/56399/comment/0172932b_3c7f0bcf PS3, Line 32: .bus_end = 11, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124831): https://review.coreboot.org/c/coreboot/+/56399/comment/38b1da05_a680501a PS3, Line 33: }, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124831): https://review.coreboot.org/c/coreboot/+/56399/comment/fd1f6605_58d36048 PS3, Line 33: }, please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)